Skip to content

Conversation

@Jjiggu
Copy link
Contributor

@Jjiggu Jjiggu commented Jun 30, 2025

작업 요약

멀티모듈 CI CD 구축

Issue Link

#3

문제점 및 어려움

해결 방안

Reference

Summary by CodeRabbit

  • New Features
    • 사용자 애플리케이션을 위한 CI/CD 배포 워크플로우와 배포 설정 파일(appspec-user.yml)이 추가되었습니다.
  • Chores
    • 관리자 및 사용자 배포 스크립트의 경로, 애플리케이션명, JAR 파일 위치 등이 사용자 애플리케이션에 맞게 수정되었습니다.
    • 관리자 배포 워크플로우의 트리거 경로가 확장 및 정렬되었습니다.
  • Style
    • 코드 파일의 불필요한 공백이 제거되었습니다.

@Jjiggu Jjiggu self-assigned this Jun 30, 2025
@coderabbitai
Copy link

coderabbitai bot commented Jun 30, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

이 변경사항은 사용자 애플리케이션을 위한 새로운 CI/CD 배포 워크플로우와 앱 배포 스펙 파일을 추가하고, 기존 관리자 배포 워크플로우의 트리거 경로와 시크릿 디코딩 방식을 수정합니다. 또한 사용자 애플리케이션 관련 배포 스크립트의 경로, 애플리케이션명, JAR 파일 위치 등을 일관되게 변경하였습니다.

Changes

파일/그룹 변경 요약
.github/workflows/deploy-admin.yml 워크플로우 트리거 경로 순서 변경 및 'infra-aws/**' 경로 추가, 시크릿 디코딩 명령 단일 라인으로 수정
.github/workflows/deploy-user.yml 사용자 애플리케이션의 CI/CD 배포 워크플로우 신규 추가
appspec-user.yml 사용자 앱 배포를 위한 앱스펙 파일 신규 추가
scripts/start-user.sh, stop-user.sh 경로, 애플리케이션명, JAR 파일 위치 등 사용자 앱에 맞게 수정
application-admin/.../ApiAdminApplication.java 파일 끝 불필요한 공백 제거(기능 변화 없음)

Sequence Diagram(s)

sequenceDiagram
    participant Dev as 개발자
    participant GitHub as GitHub Actions
    participant AWS as AWS (S3, CodeDeploy)
    participant EC2 as EC2 인스턴스

    Dev->>GitHub: develop 브랜치에 푸시 (user 관련 파일)
    GitHub->>GitHub: deploy-user 워크플로우 실행
    GitHub->>GitHub: Gradle 빌드, JAR 생성, 배포 패키지 준비
    GitHub->>AWS: S3에 배포 패키지 업로드
    GitHub->>AWS: CodeDeploy 배포 생성
    AWS->>EC2: 배포 패키지 다운로드 및 appspec-user.yml 실행
    EC2->>EC2: stop-user.sh 실행 (AfterInstall)
    EC2->>EC2: start-user.sh 실행 (ApplicationStart)
Loading

Possibly related PRs

  • #18: ApiAdminApplication.java의 불필요한 공백 제거와 관련, 동일 파일을 수정함
  • #14: deploy-admin 워크플로우 내 스크립트 및 appspec 파일 복사 단계 추가, 워크플로우 파일을 함께 수정함
  • #9: deploy-admin 워크플로우 및 관련 배포 스크립트 최초 도입, 워크플로우 변경과 직접적으로 연관

Suggested reviewers

  • HyemIin

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 05e4013 and d7c2c4c.

📒 Files selected for processing (6)
  • .github/workflows/deploy-admin.yml (2 hunks)
  • .github/workflows/deploy-user.yml (1 hunks)
  • application-admin/src/main/java/com/nowait/applicationadmin/ApiAdminApplication.java (0 hunks)
  • appspec-user.yml (1 hunks)
  • scripts/start-user.sh (1 hunks)
  • scripts/stop-user.sh (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Jjiggu Jjiggu merged commit 9236d6a into develop Jun 30, 2025
1 of 2 checks passed
@github-actions github-actions bot requested a review from HyemIin June 30, 2025 15:35
@coderabbitai coderabbitai bot mentioned this pull request Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants