Skip to content

refactor: 기존 storeId publicCode로 변경 #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jjiggu merged 1 commit into from
Aug 26, 2025
Merged

refactor: 기존 storeId publicCode로 변경 #292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .../main/java/com/nowait/applicationuser/storepayment/controller/StorePaymentController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ public class StorePaymentController {

private final StorePaymentService storePaymentService;

@GetMapping(("/{storeId}"))
@GetMapping(("/{publicCode}"))
@Operation(summary = "주점 결제 정보 조회", description = "주점 ID로 주점 결제 정보를 조회합니다.")
@ApiResponse(responseCode = "200", description = "주점 결제 정보 조회 성공")
public ResponseEntity<?> getStorePaymentByStoreId(@PathVariable Long storeId) {
Optional<StorePaymentReadDto> response = storePaymentService.getStorePaymentByStoreId(storeId);
public ResponseEntity<?> getStorePaymentByStoreId(@PathVariable String publicCode) {
Optional<StorePaymentReadDto> response = storePaymentService.getStorePaymentByStoreId(publicCode);

if (response.isPresent()) {
return ResponseEntity
Expand Down
2 changes: 1 addition & 1 deletion ...pi/src/main/java/com/nowait/applicationuser/storepayment/service/StorePaymentService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@
import com.nowait.applicationuser.storepayment.dto.StorePaymentReadDto;

public interface StorePaymentService {
Optional<StorePaymentReadDto> getStorePaymentByStoreId(Long storeId);
Optional<StorePaymentReadDto> getStorePaymentByStoreId(String publicCode);
}
13 changes: 9 additions & 4 deletions ...rc/main/java/com/nowait/applicationuser/storepayment/service/StorePaymentServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;
import com.nowait.applicationuser.storepayment.dto.StorePaymentReadDto;
import com.nowait.domaincorerdb.store.entity.Store;
import com.nowait.domaincorerdb.store.exception.StoreNotFoundException;
import com.nowait.domaincorerdb.store.repository.StoreRepository;
import com.nowait.domaincorerdb.storepayment.exception.StorePaymentParamEmptyException;
import com.nowait.domaincorerdb.storepayment.repository.StorePaymentRepository;

Expand All @@ -15,13 +18,15 @@
public class StorePaymentServiceImpl implements StorePaymentService {

private final StorePaymentRepository storePaymentRepository;
private final StoreRepository storeRepository;

@Override
@Transactional(readOnly = true)
public Optional<StorePaymentReadDto> getStorePaymentByStoreId(Long storeId) {
if (storeId == null) throw new StorePaymentParamEmptyException();

return storePaymentRepository.findByStoreId(storeId)
public Optional<StorePaymentReadDto> getStorePaymentByStoreId(String publicCode) {
if (publicCode == null) throw new StorePaymentParamEmptyException();
Store store = storeRepository.findByPublicCodeAndDeletedFalse(publicCode)
.orElseThrow(StoreNotFoundException::new);
return storePaymentRepository.findByStoreId(store.getStoreId())
.map(StorePaymentReadDto::fromEntity);
}
}