Skip to content

Conversation

@Jjiggu
Copy link
Contributor

@Jjiggu Jjiggu commented Aug 29, 2025

작업 요약

  • 주점 대기순 조회 publicCode 필드 추가

Issue Link

#290

문제점 및 어려움

해결 방안

Reference

Summary by CodeRabbit

  • 신기능
    • 매장 대기 정보 응답에 공개 코드(publicCode) 필드가 추가되어 클라이언트에서 확인할 수 있습니다.
  • 문서
    • API 문서에 공개 코드(publicCode) 필드와 예시 값이 반영되었습니다.

@Jjiggu Jjiggu self-assigned this Aug 29, 2025
@Jjiggu Jjiggu added the refactor 리팩토링 label Aug 29, 2025
@coderabbitai
Copy link

coderabbitai bot commented Aug 29, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

StoreWaitingInfo DTO에 publicCode 필드가 추가되었고, StoreServiceImpl에서 StoreWaitingInfo 생성 시 store.getPublicCode()를 전달하도록 수정되었습니다. 기타 로직이나 흐름 변경은 없습니다.

Changes

Cohort / File(s) Summary of Changes
DTO 업데이트
nowait-app-user-api/src/main/java/com/nowait/applicationuser/store/dto/StoreWaitingInfo.java
DTO에 private String publicCode 필드 및 Swagger 스키마 메타데이터 추가. Lombok AllArgsConstructor 파라미터 순서에 publicCode(\#3 위치: storeId 다음) 포함. 공개 API 표면에 게터 추가됨(롬복).
서비스 매핑 수정
nowait-app-user-api/src/main/java/com/nowait/applicationuser/store/service/StoreServiceImpl.java
getStoresByWaitingCount에서 new StoreWaitingInfo(...) 호출 시 store.getPublicCode()storeId 다음 인자로 추가. 제어 흐름 변화 없음.

Sequence Diagram(s)

sequenceDiagram
  participant Client
  participant StoreServiceImpl as StoreServiceImpl
  participant StoreRepo as StoreRepository
  participant DTO as StoreWaitingInfo

  Client->>StoreServiceImpl: getStoresByWaitingCount()
  StoreServiceImpl->>StoreRepo: findStoresWithWaitingCount()
  StoreRepo-->>StoreServiceImpl: List<Store> (including publicCode)
  Note over StoreServiceImpl: Map each Store to DTO with publicCode
  StoreServiceImpl->>DTO: new StoreWaitingInfo(imageUrl, departmentName, storeId, publicCode, storeName, waitingCount)
  StoreServiceImpl-->>Client: List<StoreWaitingInfo>
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • HyemIin

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 10261f3 and 0599488.

📒 Files selected for processing (2)
  • nowait-app-user-api/src/main/java/com/nowait/applicationuser/store/dto/StoreWaitingInfo.java (1 hunks)
  • nowait-app-user-api/src/main/java/com/nowait/applicationuser/store/service/StoreServiceImpl.java (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/#290-public-code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Jjiggu Jjiggu merged commit 6ecaca4 into develop Aug 29, 2025
1 of 2 checks passed
@github-actions github-actions bot requested a review from HyemIin August 29, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor 리팩토링

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants