-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: 토큰 재발급 로직 수정 #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. Walkthrough컨트롤러가 사용자 식별을 OAuth2 사용자 주체에서 쿠키의 accessToken으로 전환했고, 서비스는 accessToken을 받아 사용자 조회·검증 후 새 access/refresh 토큰을 생성·저장하여 AuthenticationResponse로 반환하도록 변경되었습니다. 관련 시그니처와 의존성(TokenService)도 갱신되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Client
participant Controller as UserController
participant Service as UserService
participant Repo as UserRepository
participant Jwt as JwtUtil
participant TokenSvc as TokenService
Client->>Controller: PUT /user/optional (Cookie: accessToken, body: phone, consent)
alt accessToken 누락
Controller-->>Client: 401 Unauthorized
else accessToken 존재
Controller->>Service: putOptional(accessToken, phone, consent)
Service->>Jwt: parse userId, role from accessToken
Service->>Repo: findById(userId)
Repo-->>Service: User
Service->>Repo: validate phone uniqueness / update phone & consent
Service->>Jwt: generate new access token
Service->>Jwt: generate new refresh token
Service->>TokenSvc: persist refresh token
Service-->>Controller: AuthenticationResponse(access, refresh)
Controller-->>Client: 200 OK (AuthenticationResponse)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (2)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
작업 요약
Issue Link
#310
문제점 및 어려움
해결 방안
Reference
Summary by CodeRabbit