refactor: reservation Exception 위치 변경

[Jjiggu]

작업 요약

reservation Exception 위치 변경

Issue Link

#36

문제점 및 어려움

해결 방안

Reference

Summary by CodeRabbit

• 신규 기능

  • 예약 정보를 찾을 수 없는 경우를 위한 전용 예외 메시지가 추가되었습니다.

• 버그 수정

  • 예약 상태 변경 시 존재하지 않는 예약에 대해 명확한 오류 메시지가 제공됩니다.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

이번 변경에서는 예약이 존재하지 않을 때 발생하는 예외 처리 방식을 개선하였습니다. 새로운 ReservationNotFoundException 예외 클래스를 도메인 레이어에 추가하고, 서비스 레이어에서 예약 조회 실패 시 이 예외를 명시적으로 발생시키도록 수정했습니다. 또한 관련 예외 클래스의 import 경로도 일관성 있게 변경되었습니다.

Changes

파일/경로	변경 요약
domain-reservation/src/main/java/com/nowait/reservation/exception/ReservationNotFoundException.java	ReservationNotFoundException 예외 클래스 신규 추가
application-admin/src/main/java/com/nowait/applicationadmin/exception/GlobalExceptionHandler.java application-admin/src/main/java/com/nowait/applicationadmin/reservation/service/ReservationService.java	예외 클래스 import 경로 수정 및 예약 미존재 시 명시적 예외 발생 처리

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant ReservationService
    participant ReservationRepository

    Client->>ReservationService: updateReservationStatus(reservationId, status)
    ReservationService->>ReservationRepository: findById(reservationId)
    alt 예약 존재
        ReservationRepository-->>ReservationService: Reservation 객체 반환
        ReservationService->>ReservationService: 상태 업데이트 및 저장
        ReservationService-->>Client: 처리 결과 반환
    else 예약 미존재
        ReservationRepository-->>ReservationService: null 반환
        ReservationService->>Client: ReservationNotFoundException throw
    end

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 76d91a7 and a0b6205.

📒 Files selected for processing (3)

• application-admin/src/main/java/com/nowait/applicationadmin/exception/GlobalExceptionHandler.java (1 hunks)
• application-admin/src/main/java/com/nowait/applicationadmin/reservation/service/ReservationService.java (1 hunks)
• domain-reservation/src/main/java/com/nowait/reservation/exception/ReservationNotFoundException.java (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.