Skip to content

feat(Order): order 틀 생성 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HyemIin merged 1 commit into from
Jul 2, 2025
Merged

feat(Order): order 틀 생성 #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...ion-admin/src/main/java/com/nowait/applicationadmin/order/controller/OrderController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.nowait.applicationadmin.order.controller;

import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.RequestMapping;
import org.springframework.web.bind.annotation.RestController;

Expand All @@ -11,5 +12,9 @@
@RequestMapping("admin//orders")
Copy link

@coderabbitai coderabbitai bot Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

RequestMapping 경로의 이중 슬래시를 확인하세요.

@RequestMapping("admin//orders")에서 이중 슬래시(//)가 의도된 것인지 확인이 필요합니다. 일반적으로는 단일 슬래시를 사용합니다.

다음 스크립트로 다른 컨트롤러들의 RequestMapping 패턴을 확인해보세요:

🏁 Script executed:

#!/bin/bash
# Description: Check RequestMapping patterns in other controllers to verify the intended path format

# Search for RequestMapping annotations to compare path patterns
rg -A 1 -B 1 '@RequestMapping' --type java

Length of output: 5263

@RequestMapping 경로의 이중 슬래시 제거 필요

다른 Admin 컨트롤러들이 모두 단일 슬래시 패턴("admin/users", "admin/stores")을 사용하고 있으므로, OrderController의 @RequestMapping("admin//orders")도 다음과 같이 수정해주세요:

• 파일: application-admin/src/main/java/com/nowait/applicationadmin/order/controller/OrderController.java
• 위치: 클래스 상단, 12행

- @RequestMapping("admin//orders")
+ @RequestMapping("admin/orders")
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
@RequestMapping("admin//orders")
- @RequestMapping("admin//orders")
+ @RequestMapping("admin/orders")
🤖 Prompt for AI Agents 
In
application-admin/src/main/java/com/nowait/applicationadmin/order/controller/OrderController.java
at line 12, the @RequestMapping annotation has a double slash in the path
"admin//orders". Remove the extra slash so the path becomes "admin/orders" to
maintain consistency with other Admin controllers.

@RequiredArgsConstructor
public class OrderController {
@GetMapping
public void getOrders() {
//TODO
}

}
1 change: 0 additions & 1 deletion ...ation-user/src/main/java/com/nowait/applicationuser/order/controller/OrderController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ public ResponseEntity<?> getOrderItems(
@PathVariable Long tableId,
HttpSession session
) {
// 세션ID 추출 (Spring이 세션 자동 관리)
String sessionId = session.getId();

List<OrderItemListGetResponseDto> orderItems = orderService.getOrderItems(storeId, tableId, sessionId);
Expand Down