Skip to content

Conversation

@HyemIin
Copy link
Member

@HyemIin HyemIin commented Jul 2, 2025

작업 요약

Issue Link

문제점 및 어려움

해결 방안

Reference

Summary by CodeRabbit

  • 신규 기능

    • OAuth2 로그인 성공 시, 리프레시 토큰이 HttpOnly 쿠키로 저장되고, 액세스 토큰은 리디렉션 URL의 쿼리 파라미터로 전달됩니다.
  • 개선 사항

    • 응답 방식이 JSON 반환에서 쿠키 및 리디렉션 방식으로 변경되었습니다.
    • 불필요한 변수와 코드가 정리되어 로직이 간소화되었습니다.

@HyemIin HyemIin self-assigned this Jul 2, 2025
@coderabbitai
Copy link

coderabbitai bot commented Jul 2, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

OAuth2 로그인 성공 시 토큰 반환 방식이 변경되었습니다. 기존에는 액세스 토큰과 리프레시 토큰을 JSON 응답 본문으로 반환했으나, 이제 리프레시 토큰은 HttpOnly 쿠키로 저장되고 액세스 토큰만 URL 쿼리 파라미터로 프론트엔드에 리다이렉트됩니다. 불필요한 변수와 JSON 직렬화 코드도 제거되었습니다.

Changes

파일/경로 변경 요약
external-oauth/.../OAuth2LoginSuccessHandler.java OAuth2 로그인 성공 시 토큰 반환 로직 변경, 리프레시 토큰을 HttpOnly 쿠키로 저장, 액세스 토큰은 쿼리 파라미터로 리다이렉트, 불필요한 변수 및 JSON 응답 코드 제거

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant OAuth2LoginSuccessHandler
    participant Database
    participant Frontend

    User->>OAuth2LoginSuccessHandler: OAuth2 로그인 성공
    OAuth2LoginSuccessHandler->>Database: 리프레시 토큰 저장
    OAuth2LoginSuccessHandler->>User: 리프레시 토큰을 HttpOnly 쿠키로 설정
    OAuth2LoginSuccessHandler->>Frontend: 액세스 토큰을 쿼리 파라미터로 리다이렉트
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 11938f6 and 2399095.

📒 Files selected for processing (1)
  • external-oauth/src/main/java/com/nowait/externaloauth/oauth2/OAuth2LoginSuccessHandler.java (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot requested a review from Jjiggu July 2, 2025 13:11
@HyemIin HyemIin merged commit dda0a30 into develop Jul 2, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants