-
Notifications
You must be signed in to change notification settings - Fork 0
feat: 도커 구동을 위한 sh 스크립트 추가 #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. ## Walkthrough
배포 워크플로우가 수정되어, 기존에 직접 원격에서 Docker 명령어를 실행하던 방식 대신, 새로운 `deploy-admin-docker` 스크립트를 EC2 인스턴스에 복사하고 실행하도록 변경되었습니다. 또한, 해당 스크립트가 신규로 추가되었습니다. 코드 로직 변경은 없습니다.
## Changes
| 파일/경로 | 변경 요약 |
|------------------------------------------------------|-------------------------------------------------------------------|
| .github/workflows/deploy-admin-docker.yml | 배포 단계에서 Docker 명령어 직접 실행 → deploy-admin-docker 스크립트 복사 및 실행으로 변경 |
| scripts/deploy-admin-docker | Docker 컨테이너 라이프사이클 관리용 신규 배포 스크립트 추가 |
| nowait-app-admin-api/src/.../ApiAdminApplication.java | 파일 끝에 개행 추가 (로직 변화 없음) |
## Sequence Diagram(s)
```mermaid
sequenceDiagram
participant GitHub Actions
participant EC2 Instance
GitHub Actions->>EC2 Instance: Copy deploy-admin-docker script
GitHub Actions->>EC2 Instance: chmod +x deploy-admin-docker
GitHub Actions->>EC2 Instance: Execute deploy-admin-docker
EC2 Instance->>EC2 Instance: Stop & remove old container (if exists)
EC2 Instance->>EC2 Instance: Pull latest image via docker-compose
EC2 Instance->>EC2 Instance: Start new container
EC2 Instance->>EC2 Instance: Log deployment infoPossibly related PRs
Suggested reviewers
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 요약
도커 구동을 위한 sh 스크립트 추가
Issue Link
#58
문제점 및 어려움
해결 방안
Reference
Summary by CodeRabbit