Skip to content

Conversation

@Jjiggu
Copy link
Contributor

@Jjiggu Jjiggu commented Jul 9, 2025

작업 요약

도커 구동을 위한 sh 스크립트 추가

Issue Link

#58

문제점 및 어려움

해결 방안

Reference

Summary by CodeRabbit

  • Chores
    • 배포 자동화 워크플로우가 개선되어, 배포 관련 명령어가 단일 스크립트로 통합되었습니다.
    • 새로운 배포 스크립트가 추가되어 Docker 컨테이너 배포 과정이 간소화되었습니다.

@Jjiggu Jjiggu self-assigned this Jul 9, 2025
@Jjiggu Jjiggu added the refactor 리팩토링 label Jul 9, 2025
@coderabbitai
Copy link

coderabbitai bot commented Jul 9, 2025

Caution

Review failed

The pull request is closed.

## Walkthrough

배포 워크플로우가 수정되어, 기존에 직접 원격에서 Docker 명령어를 실행하던 방식 대신, 새로운 `deploy-admin-docker` 스크립트를 EC2 인스턴스에 복사하고 실행하도록 변경되었습니다. 또한, 해당 스크립트가 신규로 추가되었습니다. 코드 로직 변경은 없습니다.

## Changes

| 파일/경로                                             | 변경 요약                                                         |
|------------------------------------------------------|-------------------------------------------------------------------|
| .github/workflows/deploy-admin-docker.yml            | 배포 단계에서 Docker 명령어 직접 실행 → deploy-admin-docker 스크립트 복사 및 실행으로 변경 |
| scripts/deploy-admin-docker                          | Docker 컨테이너 라이프사이클 관리용 신규 배포 스크립트 추가        |
| nowait-app-admin-api/src/.../ApiAdminApplication.java | 파일 끝에 개행 추가 (로직 변화 없음)                              |

## Sequence Diagram(s)

```mermaid
sequenceDiagram
    participant GitHub Actions
    participant EC2 Instance

    GitHub Actions->>EC2 Instance: Copy deploy-admin-docker script
    GitHub Actions->>EC2 Instance: chmod +x deploy-admin-docker
    GitHub Actions->>EC2 Instance: Execute deploy-admin-docker
    EC2 Instance->>EC2 Instance: Stop & remove old container (if exists)
    EC2 Instance->>EC2 Instance: Pull latest image via docker-compose
    EC2 Instance->>EC2 Instance: Start new container
    EC2 Instance->>EC2 Instance: Log deployment info

Possibly related PRs

  • Feat: 도커 도입 #75: 초기 Docker 설정 및 배포 워크플로우 도입과 관련, 동일한 배포 자동화 파일을 수정하며 Docker 배포 자동화와 관련된 PR입니다.
  • test: 도커 배포 테스트 #94: 기존 배포 워크플로우 내 Docker 컨테이너 제거 및 재시작 명령어를 스크립트로 통합하는 변경과 관련된 PR입니다.

Suggested reviewers

  • HyemIin

<!-- walkthrough_end -->
<!-- internal state start -->


<!-- DwQgtGAEAqAWCWBnSTIEMB26CuAXA9mAOYCmGJATmriQCaQDG+Ats2bgFyQAOFk+AIwBWJBrngA3EsgEBPRvlqU0AgfFwA6NPEgQAfACgjoCEYDEZyAAUASpETZWaCrKNwSPbABsvkCiQBHbGlcSHFcLzpIACIAMxJqLkAR5sATuchAG1rATebAEXHIQBBxwB1V+1hIQBKhwBsFwF7OwA6lyEAU2cAAGujIAHc0ZAcBZnUaejkw2A9sREpIACkheCIibHRkW0gMRwFRgE4AVhQsXEG/Em58RHV8Fw0YXeZtLG5sCgOR/liB1AXUAnRaekRBn3sGCng3FwyHesTQDHgXnU1A8ABF8AwANajfDcZTifAYRBndyQJSIf6AjFYfzxfwYBjSFCIBweMzrAAckAEeDx+CpGHwoV4+Ak8CUeJIuG0kXo8AwsROl2J6AE+FZPIEkWYyDITGwGBo/noJ3saIhsXgDHs+C8eHgmOQ8GY3GV7DoON2C20KrC+EgZFgmEpAw8PJEYmZ8nFDDNtHFRD+AKBIK9oQc3AOFFC8KRoyYmquo0uGDQpDYmrOADl3WhPuoLbnfKTKGqqbqSAAPW2YaiV5AtWs8Ci8/lRcW+wUE6PEjRGfTGcBQMg6p5oPCEUjkKi9BSsdhcXj8YSicRSGTyJhKKiqdRaHQTkxQOCoVCYHAEYhkdFRJjrzVcKgteyOS4uIMKMeKhqJo2i6GAhiTqYBgaEQ6iwNgAgAPQtCciKxF4+AtIgSFKLa+CyGAZbdBgYC0AiyIUBosjMF4HAGNEjEGBYkAAIIAJJPsuMJfL+zjyPgTwMF6GCkIgbi7HhmE0ewrRoRhWGtO0kDYNwtA8W6WyhtgAr3mW4bEmgviIDQ3ADNQCjcPAVI7B4AAGUkEURtAkWRFGUHZUZEpAsQ9swg6YQwRmQHZw5Ejhnnhv4YgnPI7y2XszBch4ACiADCABMWwmd6QwYMeg52QAJAA3iVHoYBIGjpRlAD6sIpVYAAyADyACatVWKx0AABKQAAvv1SFhTGSGRfA0UEKckDsdsuz+ElNCCvhMmavYpkADSDrwJB8vKqrNlCEIpu5fBvjmtAgu6koUBCSryAtvIeAlGbCuKlBbTcvwJV4MImSglykFtmBfMKyaDq9WZ8MMEYheRaYUGAb73CQnmdv4ewtpSfTyE2ojmqJEOotZ9AOfs0nOa58OUZ5I2aOcqB09SPkTf9lwCnjDB4CokStPBIXCUl9AANSNp5IO+iSGr8HNqWZZAsCHLgW0Zogpr8m2hMJY5q2hOdINWpqpb2BGvNM5z5qYmORjMZYrFeFqbaWpp2uiL9K7to8HrNicq66jcSpGhV4TWeJBhQCWjAiWJmlNkmft8AHR3BxW0gAOSCqGzhO1irRduzHgDjsqDhrEsRjox0TjtBnJtOoRGJpT4oN/Aw23UhlzikhQhoBIaBIW+SG19ouBIaxVmsS54rj7aRo5xoPd9/Rle22xnFLi+vFOP+glR5gYkSR4wn70flpIMCJqRF4AlzuWhNoGEVCQrD5AtFC5DoKECUzl7CV2eP8BJ4kRnkdeei80CeUNJER0XZnAeE5JAIW8BDRBWJFdImApMJwQYCrTEuAey+AUi0LaDYKA9j4CJWg78iDWxYvbR2aCXaSTdtnRhu846+yiP7RCyd2CpzDiWcgDEmLh2gnTHCOsm6kWppQZeTE6Hr2fCuKIDht43z3qJaQRhWKLBIN+AAQu0EoOsCzxkJECOG5MnLEWbjIignlbyah7LQbA2NNI5jzM9XYUJ4gMFkKGDwu8H6pkogoTM70+C5jYKTYe9c0CNxsaReJ8A0bwQHA/RA+pkEk0xocY4/4oq7lijAryFjj6aPQQlMGpBQj+HuPk+QhSYouGBrgGgNoL6gnFPQBKFANQYFhpDCJM1YQASgVqWGIT0x4KhgeRYaA2DA3yigJ4koNS0C2jdO6191qomQBLR6+4ibhOXGcdiX9BjXG8F4WMHhfo0H+taTxPldQvRmcMmGhMHKnSRiwFGqSdjoD1KIbJUR/S7nmWwdAyz/A5WTLcsJb1lxbEFMKYSUQhYkDOAAMXFEZa+W11B7HwdZI5CVX6IqhiM6F9AsEIqGci9ioyjKYkjC0fmL1bjki/taEICzuAlKZiGMMVIBDtCDhmAylZgroqRMgG6lLhlNnPnWGl/A8A3AvjlXAwxEHSEQJ4/ZoQEjCXWvsWhdsHbok9vFZhWcPbO3YT7ZMXDE48KDnw8QWjw6QCLHo72+NhRKg8EzfSdAuBkxWlItyCMHFYFCuY4EY08QTSKS4YRVdRGQSvBVWcD5FxKI0udDcfg0DflUX+eQ/QjzKFPKBC8EEgA== -->

<!-- internal state end -->

---

<details>
<summary>📜 Recent review details</summary>

**Configuration used: CodeRabbit UI**
**Review profile: CHILL**
**Plan: Pro**


<details>
<summary>📥 Commits</summary>

Reviewing files that changed from the base of the PR and between df71d486216970f92761f61ac6581bcc6d08e325 and aa4e1560dda4b864f30c1e9482c4d0ac443233ca.

</details>

<details>
<summary>📒 Files selected for processing (3)</summary>

* `.github/workflows/deploy-admin-docker.yml` (2 hunks)
* `nowait-app-admin-api/src/main/java/com/nowait/ApiAdminApplication.java` (1 hunks)
* `scripts/deploy-admin-docker` (1 hunks)

</details>

</details>
<!-- finishing_touch_checkbox_start -->

<details open="true">
<summary>✨ Finishing Touches</summary>

- [ ] <!-- {"checkboxId": "7962f53c-55bc-4827-bfbf-6a18da830691"} --> 📝 Generate Docstrings

</details>

<!-- finishing_touch_checkbox_end -->
<!-- tips_start -->

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

<details>
<summary>❤️ Share</summary>

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)
- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)
- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)
- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

</details>

<details>
<summary>🪧 Tips</summary>

### Chat

There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=GTable/NoWait_BE_MultiModule&utm_content=95):

- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  - `I pushed a fix in commit <commit_id>, please review it.`
  - `Explain this complex logic.`
  - `Open a follow-up GitHub issue for this discussion.`
- Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples:
  - `@coderabbitai explain this code block.`
  -	`@coderabbitai modularize this function.`
- PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.`
  - `@coderabbitai read src/utils.ts and explain its main purpose.`
  - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.`
  - `@coderabbitai help me debug CodeRabbit configuration file.`

### Support

Need help? Create a ticket on our [support page](https://www.coderabbit.ai/contact-us/support) for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

### CodeRabbit Commands (Invoked using PR comments)

- `@coderabbitai pause` to pause the reviews on a PR.
- `@coderabbitai resume` to resume the paused reviews.
- `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
- `@coderabbitai full review` to do a full review from scratch and review all the files again.
- `@coderabbitai summary` to regenerate the summary of the PR.
- `@coderabbitai generate docstrings` to [generate docstrings](https://docs.coderabbit.ai/finishing-touches/docstrings) for this PR.
- `@coderabbitai generate sequence diagram` to generate a sequence diagram of the changes in this PR.
- `@coderabbitai resolve` resolve all the CodeRabbit review comments.
- `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository.
- `@coderabbitai help` to get help.

### Other keywords and placeholders

- Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed.
- Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description.
- Add `@coderabbitai` anywhere in the PR title to generate the title automatically.

### CodeRabbit Configuration File (`.coderabbit.yaml`)

- You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository.
- Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json`

### Documentation and Community

- Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit.
- Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback.
- Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

</details>

<!-- tips_end -->

@github-actions github-actions bot requested a review from HyemIin July 9, 2025 03:04
@Jjiggu Jjiggu merged commit 60d712c into develop Jul 9, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor 리팩토링

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants