Skip to content

fix(pdm): update post_lock hook for pdm>=2.17#32

Merged
GabDug merged 1 commit into
GabDug:mainfrom
noirbizarre:fix/pdm-2.17
Jul 23, 2024
Merged

fix(pdm): update post_lock hook for pdm>=2.17#32
GabDug merged 1 commit into
GabDug:mainfrom
noirbizarre:fix/pdm-2.17

Conversation

@noirbizarre
Copy link
Copy Markdown
Collaborator

@noirbizarre noirbizarre commented Jul 22, 2024

This PR updates sync-pre-commit-lock to support pdm>=2.17 (See the breaking changes in the CHANGELOG)

CI/Tox updated to run with latest pdm/pip version (disable hashes from export so pip doesn't require hashes for all dependencies).
PDM versions from 2.14 to 2.17 added to the tox file.

Note that:

  • these cases would requires some integration tests too be able to detect them early (on release with dependabot)
  • there might be some case with multiple candidates in the list, the current fix only consider the first one

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.61%. Comparing base (8e0cb1d) to head (d5f78d6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   94.55%   94.61%   +0.05%     
==========================================
  Files           9        9              
  Lines         459      464       +5     
  Branches       80       80              
==========================================
+ Hits          434      439       +5     
  Misses         21       21              
  Partials        4        4              
Flag Coverage Δ
unittests 94.39% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@noirbizarre noirbizarre force-pushed the fix/pdm-2.17 branch 2 times, most recently from a01cc2c to 58f2f44 Compare July 23, 2024 12:59
@GabDug
Copy link
Copy Markdown
Owner

GabDug commented Jul 23, 2024

Thanks a lot @noirbizarre :)

@GabDug GabDug merged commit c1a528b into GabDug:main Jul 23, 2024
@noirbizarre noirbizarre deleted the fix/pdm-2.17 branch July 23, 2024 13:56
@noirbizarre
Copy link
Copy Markdown
Collaborator Author

You're welcome !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants