Skip to content

feat: support pdm and poetry as dependency or running instance#33

Merged
GabDug merged 3 commits into
GabDug:mainfrom
noirbizarre:feature/sync-pdm-poetry-version
Jul 25, 2024
Merged

feat: support pdm and poetry as dependency or running instance#33
GabDug merged 3 commits into
GabDug:mainfrom
noirbizarre:feature/sync-pdm-poetry-version

Conversation

@noirbizarre
Copy link
Copy Markdown
Collaborator

@noirbizarre noirbizarre commented Jul 23, 2024

This PR adds support for both pdm and poetry themselves (they both expose pre-commit hooks).

Given they are both special cases (they are not in the resolved dependencies but the running tool in charge of the virtualenv and the dependencies), they are added from the running version.

This is especially useful for the lock-related hooks which are version dependent.

@noirbizarre noirbizarre force-pushed the feature/sync-pdm-poetry-version branch from 5103dfa to 220b9e7 Compare July 23, 2024 14:01
@noirbizarre noirbizarre changed the title Feat: Support add pdm and poetry as dependency or running instance feat: support pdm and poetry as dependency or running instance Jul 23, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.65%. Comparing base (c1a528b) to head (c7bcb8f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   94.61%   94.65%   +0.04%     
==========================================
  Files           9        9              
  Lines         464      468       +4     
  Branches       80       80              
==========================================
+ Hits          439      443       +4     
  Misses         21       21              
  Partials        4        4              
Flag Coverage Δ
unittests 94.44% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@noirbizarre noirbizarre force-pushed the feature/sync-pdm-poetry-version branch from 220b9e7 to f9ad699 Compare July 23, 2024 14:13
@GabDug GabDug merged commit fe3faac into GabDug:main Jul 25, 2024
@GabDug
Copy link
Copy Markdown
Owner

GabDug commented Jul 25, 2024

Thanks @noirbizarre!

@noirbizarre noirbizarre deleted the feature/sync-pdm-poetry-version branch July 25, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants