feat: support pdm and poetry as dependency or running instance#33
Merged
Merged
Conversation
5103dfa to
220b9e7
Compare
pdm and poetry as dependency or running instancepdm and poetry as dependency or running instance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
==========================================
+ Coverage 94.61% 94.65% +0.04%
==========================================
Files 9 9
Lines 464 468 +4
Branches 80 80
==========================================
+ Hits 439 443 +4
Misses 21 21
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
220b9e7 to
f9ad699
Compare
GabDug
approved these changes
Jul 25, 2024
Owner
|
Thanks @noirbizarre! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for both
pdmandpoetrythemselves (they both exposepre-commithooks).Given they are both special cases (they are not in the resolved dependencies but the running tool in charge of the virtualenv and the dependencies), they are added from the running version.
This is especially useful for the lock-related hooks which are version dependent.