Skip to content

fix(pdm): avoid deprecation warning for PDM 2.17+ #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GabDug merged 1 commit into from
Aug 1, 2024
Merged

fix(pdm): avoid deprecation warning for PDM 2.17+ #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/sync_pre_commit_lock/pdm_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
from pdm.cli.hooks import HookManager
from pdm.core import Core
from pdm.models.candidates import Candidate
from pdm.models.repositories.lock import LockedRepository
from pdm.project import Project
from pdm.termui import UI

Expand Down Expand Up @@ -164,6 +165,12 @@ def add_arguments(self, parser: argparse.ArgumentParser) -> None:
dry_run_option.add_to_parser(parser)

def handle(self, project: Project, options: argparse.Namespace) -> None:
candidates = project.locked_repository.all_candidates
candidates = self._get_locked_repository(project).all_candidates

on_pdm_lock_check_pre_commit(project, resolution=candidates, dry_run=options.dry_run, with_prefix=False)

def _get_locked_repository(self, project: Project) -> LockedRepository:
# `locked_repository` was deprecated in PDM 2.17 favour of `get_locked_repository`, try to use it first to avoid warning
if hasattr(project, "get_locked_repository"):
return project.get_locked_repository()
return project.locked_repository