feat: also synchronize additional dependencies for Python hooks#37
Conversation
a027136 to
94f9aff
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
+ Coverage 94.06% 95.69% +1.62%
==========================================
Files 9 9
Lines 472 557 +85
Branches 81 104 +23
==========================================
+ Hits 444 533 +89
+ Misses 24 21 -3
+ Partials 4 3 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
46a9d8b to
839a137
Compare
fc35c77 to
b75323a
Compare
…isplay casing in `.pre-commit-config.yaml`
b086da7 to
bdec60b
Compare
for more information, see https://pre-commit.ci
GabDug
left a comment
There was a problem hiding this comment.
Hey @noirbizarre!
Thanks for this well-crafted PR! No worries about changing the signature; it’s not a big deal.
I just have one suggestion: could you please update the README to include the new feature and the dependency on packaging? This PR should also check off one item on the TODO list!
Aside from that, it looks good to go. I'll likely wait for your other PR to be merged before releasing version 0.7.0.
Thanks again!
45546b1 to
ceb542a
Compare
|
README updated 👍🏼 Agreed for the release. It's ready, I'll submit the PR ASAP after this one is merged 👍🏼 Thanks to you, great tool, very useful ! |
ceb542a to
85840b3
Compare
Hey 👋🏼
Here's the additional dependencies support.
I have been in another direction from your branch, but I'll update it with
the debug statements and some of the missing error handling(done).Sorry it was a big one, but I start I tried as much as possible not to change the signatures, but at some point it was just adding more complexity (eg.,
mapping,mapping_reverse_by_urlas params,...)PDM
Poetry
Note
The structure/algorithm make it easy to also handle repository renaming (like
ruff).I'll submit it in another pull requests later as it is already done too but based on this PR
Note
I added 2 dev scripts,
pdm testandpdm test-allthat were actually useful to me so I decided too submit them in the process, but I can totally remove themNote
Not done in this PR (as it is already a big one) but given
packgingis now a dependency, maybe it's worth replacing theGenericLockedPackagetype bypackging.requirements.Requirement