Skip to content

feat: also synchronize additional dependencies for Python hooks#37

Merged
GabDug merged 5 commits into
GabDug:mainfrom
noirbizarre:feature/sync-additional-dependencies
Aug 22, 2024
Merged

feat: also synchronize additional dependencies for Python hooks#37
GabDug merged 5 commits into
GabDug:mainfrom
noirbizarre:feature/sync-additional-dependencies

Conversation

@noirbizarre
Copy link
Copy Markdown
Collaborator

@noirbizarre noirbizarre commented Aug 19, 2024

Hey 👋🏼

Here's the additional dependencies support.

I have been in another direction from your branch, but I'll update it with the debug statements and some of the missing error handling (done).

Sorry it was a big one, but I start I tried as much as possible not to change the signatures, but at some point it was just adding more complexity (eg., mapping, mapping_reverse_by_url as params,...)

PDM

image

Poetry

image

Note

The structure/algorithm make it easy to also handle repository renaming (like ruff).
I'll submit it in another pull requests later as it is already done too but based on this PR

Note

I added 2 dev scripts, pdm test and pdm test-all that were actually useful to me so I decided too submit them in the process, but I can totally remove them

Note

Not done in this PR (as it is already a big one) but given packging is now a dependency, maybe it's worth replacing the GenericLockedPackage type by packging.requirements.Requirement

@noirbizarre noirbizarre force-pushed the feature/sync-additional-dependencies branch 3 times, most recently from a027136 to 94f9aff Compare August 19, 2024 12:14
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.69%. Comparing base (e3205ab) to head (85840b3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   94.06%   95.69%   +1.62%     
==========================================
  Files           9        9              
  Lines         472      557      +85     
  Branches       81      104      +23     
==========================================
+ Hits          444      533      +89     
+ Misses         24       21       -3     
+ Partials        4        3       -1     
Flag Coverage Δ
unittests 95.51% <100.00%> (+1.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@noirbizarre noirbizarre force-pushed the feature/sync-additional-dependencies branch 2 times, most recently from 46a9d8b to 839a137 Compare August 19, 2024 12:48
@noirbizarre noirbizarre force-pushed the feature/sync-additional-dependencies branch 3 times, most recently from fc35c77 to b75323a Compare August 19, 2024 21:11
@noirbizarre noirbizarre force-pushed the feature/sync-additional-dependencies branch from b086da7 to bdec60b Compare August 19, 2024 22:26
Copy link
Copy Markdown
Owner

@GabDug GabDug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @noirbizarre!

Thanks for this well-crafted PR! No worries about changing the signature; it’s not a big deal.

I just have one suggestion: could you please update the README to include the new feature and the dependency on packaging? This PR should also check off one item on the TODO list!

Aside from that, it looks good to go. I'll likely wait for your other PR to be merged before releasing version 0.7.0.

Thanks again!

@GabDug GabDug added the enhancement New feature or request label Aug 21, 2024
@GabDug GabDug linked an issue Aug 21, 2024 that may be closed by this pull request
@noirbizarre noirbizarre force-pushed the feature/sync-additional-dependencies branch from 45546b1 to ceb542a Compare August 21, 2024 23:30
@noirbizarre
Copy link
Copy Markdown
Collaborator Author

README updated 👍🏼
I also added a checkbox for the repository URL update support.

Agreed for the release. It's ready, I'll submit the PR ASAP after this one is merged 👍🏼

Thanks to you, great tool, very useful !

@noirbizarre noirbizarre force-pushed the feature/sync-additional-dependencies branch from ceb542a to 85840b3 Compare August 21, 2024 23:45
@GabDug GabDug merged commit c0ab42c into GabDug:main Aug 22, 2024
@noirbizarre noirbizarre deleted the feature/sync-additional-dependencies branch August 22, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ability to update versions in mypy hook's additional_dependencies

2 participants