feat(sync): automatically update aliased repositories URLs#38
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 95.69% 95.80% +0.11%
==========================================
Files 9 9
Lines 557 572 +15
Branches 104 105 +1
==========================================
+ Hits 533 548 +15
Misses 21 21
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
GabDug
approved these changes
Aug 24, 2024
Owner
GabDug
left a comment
GabDug
left a comment
There was a problem hiding this comment.
Looks good to me it's a nice improvement! Thanks for the special care to the display, for both PDM and Poetry.
Imo, user configuration can definitively wait, especially as we only support aliasing/renaming for 3 repositories and they're not yet user-configurable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for automatic URL update of moved repositories.
The idea is that aliased URLs are old URLs of a repository which moved (or recommend another URL like for black).
So this PR consider a repository to an aliased URL need an update and change it to the last known URL.
Attention has been ported to presentation to avoid crowding the terminal.
Here's my proposal
PDM
Poetry