Skip to content

fix(sync): ensure extras are preserved#46

Merged
GabDug merged 2 commits into
GabDug:mainfrom
noirbizarre:fix/extras
Nov 3, 2024
Merged

fix(sync): ensure extras are preserved#46
GabDug merged 2 commits into
GabDug:mainfrom
noirbizarre:fix/extras

Conversation

@noirbizarre
Copy link
Copy Markdown
Collaborator

Extras are currently removed on sync.

This PR fixes it, they are now preserved and normalized (aka. sorted alphabetically).

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (fb8c286) to head (aca7357).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files           9        9           
  Lines         572      572           
  Branches      105      105           
=======================================
  Hits          551      551           
  Misses         18       18           
  Partials        3        3           
Flag Coverage Δ
unittests 96.15% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GabDug
Copy link
Copy Markdown
Owner

GabDug commented Nov 3, 2024

Thanks @noirbizarre!

@GabDug GabDug merged commit e307103 into GabDug:main Nov 3, 2024
@noirbizarre noirbizarre deleted the fix/extras branch November 3, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants