-
Notifications
You must be signed in to change notification settings - Fork 0
might be so sad #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
might be so sad #26
Conversation
Updated repository configuration and removed local repo.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThe pacman.conf configuration file is updated to rename the local repository section from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@CodeRabbit review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pacman.conf(1 hunks)
🔇 Additional comments (1)
pacman.conf (1)
11-11: The review comment contains an incorrect premise about repository removal.The chaotic-aur and garuda repositories are not being removed in this commit. They remain present in
airootfs/etc/pacman.conf(lines 102-108). The rootpacman.conffile (where line 11 withmirror.gabeos.devis located) is a build configuration file and never contained these repositories. The concern about "removal of chaotic-aur and garuda breaking package dependencies" is therefore not applicable to the changes being made.Likely an incorrect or invalid review comment.
…g for build-iso.yml, add logo to fastfetch for flair
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request implements the gabeos-packages mirror at https://mirror.gabeos.dev, which replaces the previous local repository build process and removes dependencies on the Garuda Linux and Chaotic AUR repositories. The PR simplifies the build workflow by removing the Calamares build step from GitHub Actions, as these packages are now provided by the mirror.
Key changes:
- Adds the
gabeosrepository mirror configuration to replace local and external repositories - Removes the Calamares AUR build step from the GitHub Actions workflow
- Updates package configurations and removes
mkinitcpio-firmware
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| pacman.conf | Replaces local gabeos-local repository with remote gabeos mirror, removes chaotic-aur and garuda repositories |
| packages.x86_64 | Comments out mkinitcpio-firmware package |
| airootfs/home/archie/.zlogin | Adds comments about accessibility features |
| airootfs/home/archie/.config/fastfetch/config.jsonc | Adds comment and enables GabeOS logo in config-v2.jsonc |
| airootfs/home/archie/.config/fastfetch/config-v2.jsonc | Uncomments logo configuration to display GabeOS.png |
| airootfs/home/archie/.config/fastfetch/config-pokemon.jsonc | Adds comment about non-working package configuration |
| airootfs/home/archie/.config/fastfetch/config-compact.jsonc | Adds comment about non-working package configuration |
| airootfs/home/archie/.config/fastfetch/GabeOS.png | Adds new GabeOS logo image file |
| airootfs/etc/pacman.conf | Updates XferCommand to wget, adds gabeos repository, removes chaotic-aur and garuda repositories |
| .github/workflows/build-iso.yml | Removes Calamares build and local repository creation steps, updates pacman sync command |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "type": "packages", | ||
| "key": " ", | ||
| "keyColor": "yellow" | ||
| this doesn't work so no point including it |
Copilot
AI
Jan 8, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line breaks the JSON syntax by missing a comma at the end of the previous line. This will cause a parsing error. Either add a comma after the closing brace on line 48, or properly comment this line using JavaScript comment syntax.
| this doesn't work so no point including it | |
| // this doesn't work so no point including it |
| "type": "packages", | ||
| "key": " ", | ||
| "keyColor": "yellow" | ||
| same shit different config file |
Copilot
AI
Jan 8, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line breaks the JSON syntax by missing a comma at the end of the previous line. This will cause a parsing error. Either add a comma after the closing brace on line 49, or properly comment this line using JavaScript comment syntax.
| Server = file:///workspace/local-repo | ||
| # YOU NO TOUCH TOCUH | ||
| # -------------------------------------------------------------------- | ||
| Server = https://mirror.gabeos.dev/gabeos/os/x86_64/ |
Copilot
AI
Jan 8, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mirror URL format is inconsistent between the two pacman.conf files. In the root pacman.conf, the URL is "https://mirror.gabeos.dev/gabeos/os/x86_64/" (hardcoded architecture), while in airootfs/etc/pacman.conf, it's "https://mirror.gabeos.dev/$repo/os/$arch" (using variables). These should be consistent. The variable approach in airootfs/etc/pacman.conf is more flexible and is the standard practice.
| Server = https://mirror.gabeos.dev/gabeos/os/x86_64/ | |
| Server = https://mirror.gabeos.dev/$repo/os/$arch |
| HoldPkg = pacman glibc | ||
| XferCommand = /usr/bin/curl -L -C - -f -o %o %u | ||
| #XferCommand = /usr/bin/wget --passive-ftp -c -O %o %u | ||
| XferCommand = /usr/bin/wget -c -O %o %u |
Copilot
AI
Jan 8, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wget command is missing the "--passive-ftp" flag that was present in the commented-out version. If FTP downloads are needed, this could cause issues with firewalls. Consider whether this flag should be included.
| XferCommand = /usr/bin/wget -c -O %o %u | |
| XferCommand = /usr/bin/wget --passive-ftp -c -O %o %u |
| [options] | ||
| HoldPkg = pacman glibc | ||
| XferCommand = /usr/bin/curl -L -C - -f -o %o %u | ||
| # curl is good too |
Copilot
AI
Jan 8, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment adds no value and should be removed for a cleaner configuration file.
| # curl is good too |
| # --- local | ||
| [gabeos-local] | ||
| [gabeos] | ||
| SigLevel = Optional TrustAll |
Copilot
AI
Jan 8, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gabeos repository is configured with SigLevel = Optional TrustAll while pointing to the remote server https://mirror.gabeos.dev/gabeos/os/x86_64/. This effectively disables strict package signature verification and will accept unsigned packages or packages signed by untrusted keys, so if the mirror or TLS is compromised an attacker can serve arbitrary malicious packages that pacman will install. Configure this repository to require valid signatures from a trusted keyring (for example, by using a stricter SigLevel that requires signatures and avoids TrustAll) to ensure package integrity and authenticity.
| SigLevel = Optional TrustAll | |
| SigLevel = Required DatabaseOptional |
might so dying
implements gabeos-packages, at the following mirror:
this also removes the LOCAL mirror and plans to remove the step on the Actions to build Calamares, as it's been obsoleted by the mirror
it contains packages built fresh from Gaurda Linux and the Chaotic AUR; this is not guaranteed to be working, as they're always freshly built.
i took the time and patience to work on this. not really patience but
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.