Skip to content

Conversation

@thesomewhatyou
Copy link
Collaborator

@thesomewhatyou thesomewhatyou commented Dec 14, 2025

might so dying

implements gabeos-packages, at the following mirror:

https://mirror.gabeos.dev

this also removes the LOCAL mirror and plans to remove the step on the Actions to build Calamares, as it's been obsoleted by the mirror

it contains packages built fresh from Gaurda Linux and the Chaotic AUR; this is not guaranteed to be working, as they're always freshly built.

i took the time and patience to work on this. not really patience but

Summary by CodeRabbit

  • Chores
    • Updated package repository configuration to use remote mirror instead of local source.
    • Renamed repository section and updated server endpoint URL.
    • Removed deprecated repository sections from configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

Updated repository configuration and removed local repo.
@coderabbitai
Copy link

coderabbitai bot commented Dec 14, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

The pacman.conf configuration file is updated to rename the local repository section from [gabeos-local] to [gabeos], replace its local file path with a remote HTTPS mirror server URL (https://mirror.gabeos.dev/$repo/os/$arch), and remove the chaotic-aur and garuda repository sections entirely. Core/extra/multilib includes remain unchanged.

Changes

Cohort / File(s) Summary
Repository Configuration Update
pacman.conf
Renames [gabeos-local] section to [gabeos], updates Server URL from local path to remote HTTPS mirror (https://mirror.gabeos.dev/$repo/os/$arch), removes [chaotic-aur] and [garuda] repository sections, updates accompanying comments

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Straightforward configuration edits with clear intent (repository rename and remote mirror substitution)
  • Section removals are explicit and unambiguous
  • Verify mirror URL validity and that removal of repositories is intentional

Possibly related PRs

Poem

🐰 From local files to clouds so high,
The gabeos mirror takes its flight,
Chaotic repos bid their goodbye,
Remote and clean, a mirror's delight! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'might be so sad' is vague and does not convey meaningful information about the changeset, which involves implementing gabeos-packages, updating repository mirrors, and removing local/chaotic-aur sections. Revise the title to clearly describe the main change, such as 'Update pacman.conf to use remote gabeos mirror' or 'Implement gabeos-packages with remote mirror configuration'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thesomewhatyou
Copy link
Collaborator Author

@CodeRabbit review

@coderabbitai
Copy link

coderabbitai bot commented Dec 14, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 75e6188 and abb86c1.

📒 Files selected for processing (1)
  • pacman.conf (1 hunks)
🔇 Additional comments (1)
pacman.conf (1)

11-11: The review comment contains an incorrect premise about repository removal.

The chaotic-aur and garuda repositories are not being removed in this commit. They remain present in airootfs/etc/pacman.conf (lines 102-108). The root pacman.conf file (where line 11 with mirror.gabeos.dev is located) is a build configuration file and never contained these repositories. The concern about "removal of chaotic-aur and garuda breaking package dependencies" is therefore not applicable to the changes being made.

Likely an incorrect or invalid review comment.

@GabeOS-Arch GabeOS-Arch deleted a comment from coderabbitai bot Dec 14, 2025
@thesomewhatyou thesomewhatyou marked this pull request as ready for review January 8, 2026 00:50
Copilot AI review requested due to automatic review settings January 8, 2026 00:50
@thesomewhatyou thesomewhatyou merged commit e9f8732 into the-working-iso-branch Jan 8, 2026
6 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request implements the gabeos-packages mirror at https://mirror.gabeos.dev, which replaces the previous local repository build process and removes dependencies on the Garuda Linux and Chaotic AUR repositories. The PR simplifies the build workflow by removing the Calamares build step from GitHub Actions, as these packages are now provided by the mirror.

Key changes:

  • Adds the gabeos repository mirror configuration to replace local and external repositories
  • Removes the Calamares AUR build step from the GitHub Actions workflow
  • Updates package configurations and removes mkinitcpio-firmware

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
pacman.conf Replaces local gabeos-local repository with remote gabeos mirror, removes chaotic-aur and garuda repositories
packages.x86_64 Comments out mkinitcpio-firmware package
airootfs/home/archie/.zlogin Adds comments about accessibility features
airootfs/home/archie/.config/fastfetch/config.jsonc Adds comment and enables GabeOS logo in config-v2.jsonc
airootfs/home/archie/.config/fastfetch/config-v2.jsonc Uncomments logo configuration to display GabeOS.png
airootfs/home/archie/.config/fastfetch/config-pokemon.jsonc Adds comment about non-working package configuration
airootfs/home/archie/.config/fastfetch/config-compact.jsonc Adds comment about non-working package configuration
airootfs/home/archie/.config/fastfetch/GabeOS.png Adds new GabeOS logo image file
airootfs/etc/pacman.conf Updates XferCommand to wget, adds gabeos repository, removes chaotic-aur and garuda repositories
.github/workflows/build-iso.yml Removes Calamares build and local repository creation steps, updates pacman sync command

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"type": "packages",
"key": "󰏖 ",
"keyColor": "yellow"
this doesn't work so no point including it
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line breaks the JSON syntax by missing a comma at the end of the previous line. This will cause a parsing error. Either add a comma after the closing brace on line 48, or properly comment this line using JavaScript comment syntax.

Suggested change
this doesn't work so no point including it
// this doesn't work so no point including it

Copilot uses AI. Check for mistakes.
"type": "packages",
"key": "󰏖 ",
"keyColor": "yellow"
same shit different config file
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line breaks the JSON syntax by missing a comma at the end of the previous line. This will cause a parsing error. Either add a comma after the closing brace on line 49, or properly comment this line using JavaScript comment syntax.

Copilot uses AI. Check for mistakes.
Server = file:///workspace/local-repo
# YOU NO TOUCH TOCUH
# --------------------------------------------------------------------
Server = https://mirror.gabeos.dev/gabeos/os/x86_64/
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mirror URL format is inconsistent between the two pacman.conf files. In the root pacman.conf, the URL is "https://mirror.gabeos.dev/gabeos/os/x86_64/" (hardcoded architecture), while in airootfs/etc/pacman.conf, it's "https://mirror.gabeos.dev/$repo/os/$arch" (using variables). These should be consistent. The variable approach in airootfs/etc/pacman.conf is more flexible and is the standard practice.

Suggested change
Server = https://mirror.gabeos.dev/gabeos/os/x86_64/
Server = https://mirror.gabeos.dev/$repo/os/$arch

Copilot uses AI. Check for mistakes.
HoldPkg = pacman glibc
XferCommand = /usr/bin/curl -L -C - -f -o %o %u
#XferCommand = /usr/bin/wget --passive-ftp -c -O %o %u
XferCommand = /usr/bin/wget -c -O %o %u
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wget command is missing the "--passive-ftp" flag that was present in the commented-out version. If FTP downloads are needed, this could cause issues with firewalls. Consider whether this flag should be included.

Suggested change
XferCommand = /usr/bin/wget -c -O %o %u
XferCommand = /usr/bin/wget --passive-ftp -c -O %o %u

Copilot uses AI. Check for mistakes.
[options]
HoldPkg = pacman glibc
XferCommand = /usr/bin/curl -L -C - -f -o %o %u
# curl is good too
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment adds no value and should be removed for a cleaner configuration file.

Suggested change
# curl is good too

Copilot uses AI. Check for mistakes.
# --- local
[gabeos-local]
[gabeos]
SigLevel = Optional TrustAll
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gabeos repository is configured with SigLevel = Optional TrustAll while pointing to the remote server https://mirror.gabeos.dev/gabeos/os/x86_64/. This effectively disables strict package signature verification and will accept unsigned packages or packages signed by untrusted keys, so if the mirror or TLS is compromised an attacker can serve arbitrary malicious packages that pacman will install. Configure this repository to require valid signatures from a trusted keyring (for example, by using a stricter SigLevel that requires signatures and avoids TrustAll) to ensure package integrity and authenticity.

Suggested change
SigLevel = Optional TrustAll
SigLevel = Required DatabaseOptional

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants