Fix timeout not working for functions using recvpred.#616
Closed
peter50216 wants to merge 1 commit intoGallopsled:masterfrom
Closed
Fix timeout not working for functions using recvpred.#616peter50216 wants to merge 1 commit intoGallopsled:masterfrom
peter50216 wants to merge 1 commit intoGallopsled:masterfrom
Conversation
For example, recvregex.
Contributor
Author
|
Don't know why travis test fail... It does pass in my VM, and the error doesn't seems to be relevant to the changed code. Could someone rerun the travis test please? |
Contributor
Author
|
Accidentally deleted the commit on github :(. Reopened. |
Contributor
|
@zachriggle: Is this still relevant after #636? |
Member
|
The reporter did not provide a test case which failed, only some code changes which now cause merge conflicts. Everything looks like it works for me, after #636. |
Kyle-Kyle
pushed a commit
to Kyle-Kyle/pwntools
that referenced
this pull request
Apr 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example, recvregex.
Also delete some useless code.