Skip to content

Fix timeout not working for functions using recvpred.#616

Closed
peter50216 wants to merge 1 commit intoGallopsled:masterfrom
peter50216:master
Closed

Fix timeout not working for functions using recvpred.#616
peter50216 wants to merge 1 commit intoGallopsled:masterfrom
peter50216:master

Conversation

@peter50216
Copy link
Copy Markdown
Contributor

For example, recvregex.

Also delete some useless code.

@peter50216
Copy link
Copy Markdown
Contributor Author

Don't know why travis test fail... It does pass in my VM, and the error doesn't seems to be relevant to the changed code. Could someone rerun the travis test please?

@peter50216
Copy link
Copy Markdown
Contributor Author

Accidentally deleted the commit on github :(. Reopened.

@TethysSvensson
Copy link
Copy Markdown
Contributor

@zachriggle: Is this still relevant after #636?

@zachriggle
Copy link
Copy Markdown
Member

The reporter did not provide a test case which failed, only some code changes which now cause merge conflicts.

Everything looks like it works for me, after #636.

>>> r=remote('google.com', 80, timeout=3)
[x] Opening connection to google.com on port 80
[x] Opening connection to google.com on port 80: Trying 2a00:1450:4009:808::200e
[+] Opening connection to google.com on port 80: Done
>>> r.recvregex('foobar')
''

@zachriggle zachriggle closed this Jul 18, 2016
Kyle-Kyle pushed a commit to Kyle-Kyle/pwntools that referenced this pull request Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants