Fix cyclic_find packing when subseq=int#622
Closed
push0ebp wants to merge 1 commit intoGallopsled:masterfrom
push0ebp:master
Closed
Fix cyclic_find packing when subseq=int#622push0ebp wants to merge 1 commit intoGallopsled:masterfrom push0ebp:master
push0ebp wants to merge 1 commit intoGallopsled:masterfrom
push0ebp:master
Conversation
Author
|
hi |
Contributor
|
This was fixed as part of #636. |
Kyle-Kyle
pushed a commit
to Kyle-Kyle/pwntools
that referenced
this pull request
Apr 25, 2021
* Use ArgparsedCommand for commands/gdbinit.py * Use ArgparsedCommand for commands/gdbinit.py * Use ArgparsedCommand for commands/dt.py * Use ArgparsedCommand for commands/defcon.py. (Not sure what the other one command in there did, didn't bother making it argparsed * Use ArgparsedCommand for commands/context.py * Use argparsed command for commands/argv.py * Use ArgparsedCommand for commands/heap.py * Use ArgparsedCommand for commands/ida.py * Use ArgparsedCommand for commands/misc.py * Use ArgparsedCommand for commands/next.py and commands/nearpc.py * Use ArgparsedCommand for commands/peda.py * Use ArgparsedCommand for commands/pie.py * Use ArgparsedCommand for commands/procinfo.py * Use ArgparsedCommand for commands/reload.py * Use ArgparsedCommand for commands/rop.py * Use ArgparsedCommand for commands/segments.py * Use ArgparsedCommand for commands/start.py * Use ArgparsedCommand for commands/telescope.py * Use ArgparsedCommand for commands/version.py * Use ArgparsedCommand for commands/vmmap.py * Use ArgparsedCommand for commands/windbg.py * Use ArgparsedCommand for commands/xor.py * Use ArgparsedCommand for commands/windbg.py * Fix isort
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when instance of cyclic_find subseq argument is int, int to str packing is not working.
because any iter before isinstance check
before
def cyclic_find(subseq, alphabet = string.ascii_lowercase, n = None):
...
if any(c not in alphabet for c in subseq):
return -1
after
def cyclic_find(subseq, alphabet = string.ascii_lowercase, n = 0):
...
it worked