fix: 1.21.9 player api changes #11
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Player Finder mod for compatibility with Minecraft 1.21.9, specifically addressing API changes where the getWorld() method was replaced with getEntityWorld() in the player API.
- Updated Minecraft version from 1.21 to 1.21.9 with exact version matching
- Changed player API calls from
getWorld()togetEntityWorld()in PlayerFinder.java - Updated all dependencies including Fabric Loader (0.16.0 → 0.18.4), Yarn mappings, and Fabric API (0.102.0 → 0.134.1)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/main/resources/fabric.mod.json | Updated Minecraft dependency to exact version 1.21.9 and Fabric API to require >=0.134.1 |
| src/main/java/me/imgalvin/playerfinder/PlayerFinder.java | Fixed player API deprecation by replacing getWorld() with getEntityWorld() calls |
| gradle.properties | Updated build properties for Minecraft 1.21.9, Yarn mappings, Fabric Loader 0.18.4, and Fabric API 0.134.1 |
| README.md | Added version compatibility badge, updated changelog, and revised version compatibility documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | 1.0.0 | 1.21 - 1.21.1 | 1.0.0+1.21 | | ||
| [](https://modrinth.com/mod/playerfinder) | ||
|
|
||
| AutoTorcher is available for Minecraft versions 1.20 and above! |
There was a problem hiding this comment.
The documentation mentions "AutoTorcher" instead of the correct mod name "PlayerFinder". This appears to be copied from another project.
| AutoTorcher is available for Minecraft versions 1.20 and above! | |
| PlayerFinder is available for Minecraft versions 1.20 and above! |
| "depends": { | ||
| "fabricloader": ">=0.16.0", | ||
| "minecraft": "~1.21", | ||
| "minecraft": "1.21.9", |
There was a problem hiding this comment.
The Minecraft version constraint is now an exact version match ("1.21.9") rather than a version range. While the README mentions this is intentional to prevent crashes, this means the mod will not work with 1.21.10 or any future patch versions without an update. Consider using a tilde constraint like "~1.21.9" to allow compatible patch versions (e.g., 1.21.10, 1.21.11), or if breaking changes are expected in every patch version, consider documenting why this strict versioning is necessary.
| "minecraft": "1.21.9", | |
| "minecraft": "~1.21.9", |
| ] | ||
| }, | ||
| "depends": { | ||
| "fabricloader": ">=0.16.0", |
There was a problem hiding this comment.
The fabricloader version in gradle.properties was updated to 0.18.4, but the fabric.mod.json dependency still requires ">=0.16.0". For consistency and to ensure users have the latest loader features, consider updating the fabric.mod.json dependency to require ">=0.18.4" to match the development environment.
| "fabricloader": ">=0.16.0", | |
| "fabricloader": ">=0.18.4", |
No description provided.