chore: release 1.21.11 #13
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the mod to support Minecraft version 1.21.10, including dependency updates and API method changes to maintain compatibility with the newer Minecraft version.
Key Changes:
- Updated Minecraft, Fabric Loader, and Fabric API version dependencies
- Changed
getWorld()togetEntityWorld()method calls for compatibility with newer Minecraft API - Added changelog entries for recent version releases
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| src/main/resources/fabric.mod.json | Updated dependency requirements for fabricloader, minecraft, and fabric-api versions |
| src/main/java/me/imgalvin/playerfinder/PlayerFinder.java | Updated API calls from getWorld() to getEntityWorld() for Minecraft 1.21.10 compatibility |
| gradle.properties | Updated Minecraft version, yarn mappings, loader version, mod version, and fabric version; fixed capitalization of "Gradle" in comment |
| README.md | Added new changelog entries and version compatibility information; replaced version table with badge |
Critical Issues Found:
- Multiple version inconsistencies: The PR is titled "release 1.21.10" but several files reference "1.21.11" or the typo "1.22.11" and "1.22.10"
- Incorrect mod name reference: README mentions "AutoTorcher" instead of "PlayerFinder"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
README.md
Outdated
| ## 1.0.3 (1.22.10) | ||
| * For 1.22.10 compatibility |
There was a problem hiding this comment.
The changelog entry is labeled as "1.22.10" but this appears to be a typo. This should be "1.21.10" to correctly reference Minecraft version 1.21.10 instead of a non-existent 1.22.10 version.
| ## 1.0.3 (1.22.10) | |
| * For 1.22.10 compatibility | |
| ## 1.0.3 (1.21.10) | |
| * For 1.21.10 compatibility |
README.md
Outdated
| ## 1.0.3 (1.22.10) | ||
| * For 1.22.10 compatibility |
There was a problem hiding this comment.
The version reference "1.22.10" in the compatibility note is inconsistent with the changelog header on line 36. Both should reference the same version, and should be "1.21.10" instead of "1.22.10".
| ## 1.0.3 (1.22.10) | |
| * For 1.22.10 compatibility | |
| ## 1.0.3 (1.21.10) | |
| * For 1.21.10 compatibility |
| "fabricloader": ">=0.16.0", | ||
| "minecraft": "~1.21", | ||
| "fabricloader": ">=0.17.3", | ||
| "minecraft": "1.21.11", |
There was a problem hiding this comment.
The Minecraft version is specified as "1.21.11" but the PR title indicates this is a release for version "1.21.10". There's a version mismatch that needs to be corrected. This should likely be "1.21.10" to match the release version in the PR title.
| "minecraft": "1.21.11", | |
| "minecraft": "1.21.10", |
| | 1.0.0 | 1.21 - 1.21.1 | 1.0.0+1.21 | | ||
| [](https://modrinth.com/mod/playerfinder) | ||
|
|
||
| AutoTorcher is available for Minecraft versions 1.20 and above! |
There was a problem hiding this comment.
This line refers to "AutoTorcher" but this is the "PlayerFinder" mod. This appears to be copied from another project and should be corrected to reference the correct mod name.
| AutoTorcher is available for Minecraft versions 1.20 and above! | |
| Player Finder is available for Minecraft versions 1.20 and above! |
README.md
Outdated
| ## 1.0.4 (1.22.11) | ||
| * For 1.22.11 compatibility | ||
| * Updated dependencies | ||
|
|
||
| ## 1.0.3 (1.22.10) | ||
| * For 1.22.10 compatibility |
There was a problem hiding this comment.
The changelog entry is labeled as "1.22.11" but this appears to be a typo. Based on the PR title and context, this should be "1.21.11" or more likely "1.21.10" to match the release version.
| ## 1.0.4 (1.22.11) | |
| * For 1.22.11 compatibility | |
| * Updated dependencies | |
| ## 1.0.3 (1.22.10) | |
| * For 1.22.10 compatibility | |
| ## 1.0.4 (1.21.11) | |
| * For 1.21.11 compatibility | |
| * Updated dependencies | |
| ## 1.0.3 (1.21.10) | |
| * For 1.21.10 compatibility |
| minecraft_version=1.21 | ||
| yarn_mappings=1.21+build.9 | ||
| loader_version=0.16.0 | ||
| minecraft_version=1.21.11 |
There was a problem hiding this comment.
The minecraft_version is set to "1.21.11" but the PR title indicates this is a release for version "1.21.10". This version mismatch needs to be corrected to ensure consistency across the project. It should likely be "1.21.10".
| yarn_mappings=1.21+build.9 | ||
| loader_version=0.16.0 | ||
| minecraft_version=1.21.11 | ||
| yarn_mappings=1.21.11+build.3 |
There was a problem hiding this comment.
The yarn_mappings version is set to "1.21.11+build.3" but the PR title indicates this is for Minecraft version "1.21.10". The yarn mappings version should match the Minecraft version and be "1.21.10+build.X" instead.
| yarn_mappings=1.21.11+build.3 | |
| yarn_mappings=1.21.10+build.3 |
|
|
||
| # Mod Properties | ||
| mod_version=1.0.1+1.21 | ||
| mod_version=1.0.4+1.21.11 |
There was a problem hiding this comment.
The mod_version includes "1.21.11" but the PR title indicates this is a release for version "1.21.10". The mod version should be "1.0.4+1.21.10" to maintain consistency with the Minecraft version being released.
| mod_version=1.0.4+1.21.11 | |
| mod_version=1.0.4+1.21.10 |
|
|
||
| # Dependencies | ||
| fabric_version=0.102.0+1.21 | ||
| fabric_version=0.140.2+1.21.11 |
There was a problem hiding this comment.
The fabric_version includes "1.21.11" but the PR title indicates this is a release for Minecraft version "1.21.10". The fabric version should be updated to match the correct Minecraft version (e.g., "0.140.2+1.21.10").
| fabric_version=0.140.2+1.21.11 | |
| fabric_version=0.140.2+1.21.10 |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.