Fix regex, Doxygen, etc. invalid-escape warnings (v2)#552
Open
Fix regex, Doxygen, etc. invalid-escape warnings (v2)#552
Conversation
…ds, mainly by using proper raw strings where escapes are expected
Collaborator
Author
|
Note that it's easier to view the diff with whitespace changes hidden, due to a lot of trailing spaces, particularly in the header generation. Click the settings cog in the GitHub "Files changed" tab. |
Collaborator
|
Trying to build this locally fails. This seems to generate additional slashes that break the build. For example, in Models/src/particle_database.cpp: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Python 3.6 onwards, strings containing invalid escape sequences lead to noisy warnings, since these were previously passed through safely but now can be misinterpreted as generic Unicode escapes rather than specific C/Python string sequences.
We're getting a lot of these from the regex-heavy harvester machinery, and from Doxygen backslash escapes (these could be @ signs) in generated headers. It's more than a build-cleanliness issue, since these warnings are scheduled to become syntax errors in an upcoming Python 3.x release.
I've attempted to fix them, using mainly raw r"" strings. Let's see if the CI flags any issues with the generated output.