Skip to content

Full Cotire Support#8

Closed
cwfitzgerald wants to merge 10 commits into
GameFoundry:masterfrom
cwfitzgerald:cotire
Closed

Full Cotire Support#8
cwfitzgerald wants to merge 10 commits into
GameFoundry:masterfrom
cwfitzgerald:cotire

Conversation

@cwfitzgerald
Copy link
Copy Markdown

@cwfitzgerald cwfitzgerald commented Jun 4, 2018

This is the examples equivalent to GameFoundry/B3DFramework#142.

It also adds basic travis support.

@cwfitzgerald cwfitzgerald changed the title Add Full Cotire Support Full Cotire Support Jun 4, 2018
@BearishSun
Copy link
Copy Markdown
Member

Do we need cotire for examples since they are only one source file?

Also I don't plan on setting up CI for examples at the moment, and when I do I'd like to somehow re-use the travis/appveyor for both projects so I don't need to maintain mostly duplicate code.

@cwfitzgerald
Copy link
Copy Markdown
Author

cwfitzgerald commented Jun 6, 2018

I would argue yes, as we want people who are reading the examples to know that (conditional) cotiring exists in the codebase and we have facilities to do that. People are much more likely to look at the examples then directly read the manual. We can remove cotire.cmake though.

That's also fine.

It would probably be easier to just close this PR and you can put in cotire and the colored output thing.

@BearishSun
Copy link
Copy Markdown
Member

Makes sense. I've enabled cotire on the relevant targets, and the rest of the changes should be inherited from the framework's cmake.

@BearishSun BearishSun closed this Jun 6, 2018
@cwfitzgerald
Copy link
Copy Markdown
Author

cwfitzgerald commented Jun 6, 2018 via email

@BearishSun
Copy link
Copy Markdown
Member

I've moved that code into Properties.cmake, which gets included from the root CMakeLists.txt for examples, bsf and custom user projects. I haven't tested it but I think that should be fine?

@cwfitzgerald
Copy link
Copy Markdown
Author

cwfitzgerald commented Jun 6, 2018 via email

@ourui ourui mentioned this pull request Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants