Conversation
NikoGrano
approved these changes
Mar 1, 2020
Eirmas
approved these changes
Mar 1, 2020
NikoGrano
requested changes
Mar 1, 2020
Member
NikoGrano
left a comment
NikoGrano
left a comment
There was a problem hiding this comment.
ERROR Failed to compile with 2 errors3:37:36 PM
This dependency was not found:
* @/store/modules/room in ./node_modules/cache-loader/dist/cjs.js??ref--14-0!./node_modules/thread-loader/dist/cjs.js!./node_modules/babel-loader/lib!./node_modules/ts-loader??ref--14-3!./node_modules/cache-loader/dist/cjs.js??ref--0-0!./node_modules/vue-loader/lib??vue-loader-options!./src/App.vue?vue&type=script&lang=ts&, ./src/store/index.ts
To install it, you can run: npm install --save @/store/modules/room
@bryansamuel1 Please verify your code. This cannot be merged like this.
Eirmas
approved these changes
Mar 1, 2020
Member
|
I cannot dismiss this pr at all, from my deck, due it shows it still needs a review... |
2 tasks
NikoGrano
pushed a commit
that referenced
this pull request
Mar 6, 2020
* 93 - Set up room state * Fix build and bug
NikoGrano
pushed a commit
that referenced
this pull request
Mar 6, 2020
* 93 - Set up room state * Fix build and bug
bryansamuel1
added a commit
that referenced
this pull request
Mar 29, 2020
* 93 - Set up room state * Fix build and bug
bryansamuel1
added a commit
that referenced
this pull request
Mar 29, 2020
* 93 - Set up room state * Fix build and bug
NikoGrano
pushed a commit
that referenced
this pull request
May 3, 2020
* 93 - Set up room state * Fix build and bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.