fix: avoid unnecessary error throwing (rebased from PR #14)#21
Merged
GasStationManager merged 1 commit intomainfrom Mar 7, 2026
Merged
fix: avoid unnecessary error throwing (rebased from PR #14)#21GasStationManager merged 1 commit intomainfrom
GasStationManager merged 1 commit intomainfrom
Conversation
Port of remove-error-throwing branch onto current main: - Log to stderr (IO.eprintln) instead of stdout for all diagnostic output - Fix typo: environement -> environment - runSafeVerify returns (HashMap × Bool) instead of throwing on check failure - Axiom violations logged instead of thrown, allowing JSON output to be written - JSON output always saved when --save is specified (even on failure) - Add verbose flag hint in error message - TODO comment on safety mismatch unreachability Co-authored-by: Paul Lezeau Supersedes #14.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased port of #14 (
remove-error-throwingby Paul Lezeau) onto current main.Changes
IO.eprintlninstead ofIO.println, keeping stdout clean for programmatic useenvironement→environmentrunSafeVerifyreturns(HashMap × Bool)instead of throwing when the solution fails verification. Errors are still thrown for malformed input (missing files, unsafe constants, etc.)--saveoutput is created even when the check fails, making it useful for downstream tooling-vflag when not already enabledprintVerboseOpaqueMismatchis currently unreachableCo-authored-by: Paul Lezeau
Supersedes #14.
Test results
All 12 test cases pass (attacks rejected, benign cases accepted, JSON written on both success and failure).