Perl::Tidy for URCA Perl Files
#185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Updating with rebase |
dchansen06
added
Documentation
Contributor
|
Updating with rebase |
Signed-off-by: ReginaldWang <114448545+ReginaldWang@users.noreply.github.com>
Signed-off-by: ReginaldWang <114448545+ReginaldWang@users.noreply.github.com>
Signed-off-by: ReginaldWang <114448545+ReginaldWang@users.noreply.github.com>
dchansen06
added
1 URGENT
…n@v6 and streamline package installation
Signed-off-by: Daniel Hansen <105574022+dchansen06@users.noreply.github.com>
Contributor
|
Also had to optimize a bit of how Gersemi (CMake formatter) works, sadly it is in this PR but it is small enough and on-topic enough I will keep it in for now |
dchansen06
added a commit
that referenced
this pull request
Feb 1, 2026
3 tasks
dchansen06
added a commit
that referenced
this pull request
Feb 1, 2026
# Copy `Perl::Tidy` Into `main` ## Problem and Scope During some confusion #185 got changed inside of #176 which broke functionality ## Description This adds it to `main` so that it can be pulled in and future changes can be noted explicitely ## Gotchas and Limitations None ## Testing - [x] HOOTL testing - [ ] HITL testing - [x] Human tested ### Testing Details Already tested in #185 ## Larger Impact None ## Additional Context and Ticket Direct copy of #185
3 tasks
dchansen06
added a commit
that referenced
this pull request
Feb 1, 2026
# Implement Perl Critic ## Problem and Scope Trying to resolve issue #174 for CAN URCA, who are writing in Perl. A Perl::Critic implementation was desired for verifying commits. ## Description Added a minimal Perl::Critic file with an appropriate GitHub Action in a .yml file, which is named similarly. Outputs to `$GITHUB_STEP_SUMMARY` and as GitHub annotations within the PR context ## Gotchas and Limitations A .perlcritic file allows for a range of harshness when it comes to checking, as well as how descriptive it is in describing errors. This ranges from 1-5 and 1-11, respectively. ## Testing - [x] HOOTL testing - [ ] HITL testing - [x] Human tested ### Testing Details Tested by copying current Perl code in and checking output of action by hand ## Larger Impact Will help Perl code be nicely written ## Additional Context and Ticket Resolves #174 Helps #176 Parallel to #185 --------- Co-authored-by: Daniel Hansen <dchansen06@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup Perl Tidy and Action
Problem and Scope
Similar to Perl Critic, clean up the URCA Perl code
Description
Automatically formats the Perl code
Gotchas and Limitations
Includes some minor bugfixes to URCA code
Testing
Testing Details
Works still
Larger Impact
Easier to maintain
Additional Context and Ticket
See #173, related to #174