Merged
Conversation
…naming collision from a bad citizen 3rd party addon
|
It really sucks that people need to do this in unrelated addons, but to solve this on ember-leaflet would mean introducing a breaking change (renaming the helper). Also, if I prefix the helper to However, in my defense:
|
bakerac4
reviewed
Jul 9, 2018
| @@ -1,5 +1,5 @@ | |||
| {{#if hasIcon}} | |||
| {{fa-icon icon class="action-button-icon"}} | |||
| {{fa-icon this.icon class="action-button-icon"}} | |||
Contributor
There was a problem hiding this comment.
@billdami can you add a comment above this line explaining why we need to do this. I know we will forgot at some point and it would be nice to have a reminder in the code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for issue caused by ember-leaftlet's inclusion of a helper called
icon, which collides with theiconcomponent property, as global helper's take precendence over property names in the ember resolver.see: miguelcobain/ember-leaflet#175
cc @miguelcobain