Fix #142 by adjusting data structure of fixed_positions and fixed_directors
#147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoelzle
requested review from
armantekinalp,
bhosale2 and
skim0119
as code owners
bhosale2
requested changes
Jul 19, 2022
Collaborator
bhosale2
left a comment
bhosale2
left a comment
There was a problem hiding this comment.
LGTM mostly, super minor changes.
skim0119
requested changes
Jul 20, 2022
Collaborator
skim0119
left a comment
skim0119
left a comment
There was a problem hiding this comment.
LGTM. One change request
…` vector Unrolling vector manually is usually faster
skim0119
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142 by implementing the following changes:
fixed_positionsandfixed_directorsafter initialization to mirror the standard data structure inpyelastica, which is batch-last as in(dim, batch)or(dim, dim,batch)...for slicing of vector entries instead of listing each dim separately