Skip to content

(#150) add pre commit to pyelastica #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bhosale2 merged 8 commits into from
Jul 21, 2022
Merged

(#150) add pre commit to pyelastica #151

bhosale2 merged 8 commits into from
Jul 21, 2022

Conversation

@bhosale2
Copy link
Collaborator

@bhosale2 bhosale2 commented Jul 20, 2022

Fixes #150.

@bhosale2 bhosale2 added the enhancement New feature or request label Jul 20, 2022
@bhosale2 bhosale2 added this to the Version 0.3 milestone Jul 20, 2022
@bhosale2 bhosale2 self-assigned this Jul 20, 2022
@bhosale2 bhosale2 requested a review from armantekinalp as a code owner July 20, 2022 21:10
@bhosale2 bhosale2 linked an issue Jul 20, 2022 that may be closed by this pull request
Add pre-commit to PyElastica #150
Closed
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2022 •
edited
Loading

Codecov Report

Merging #151 (54e35ad) into update-0.3.0 (8b120cc) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           update-0.3.0     #151   +/-   ##
=============================================
  Coverage         87.58%   87.58%           
=============================================
  Files                43       43           
  Lines              2780     2780           
  Branches            361      361           
=============================================
  Hits               2435     2435           
  Misses              326      326           
  Partials             19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b120cc...54e35ad. Read the comment docs.

armantekinalp
armantekinalp approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhosale2 bhosale2 merged commit 5213d6f into GazzolaLab:update-0.3.0 Jul 21, 2022
@bhosale2 bhosale2 deleted the 150_add_pre_commit branch July 21, 2022 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@armantekinalp armantekinalp armantekinalp approved these changes

Assignees

@bhosale2 bhosale2

Labels

enhancement New feature or request

Projects

None yet

Milestone

Version 0.3

Development

Successfully merging this pull request may close these issues.

Add pre-commit to PyElastica

3 participants

@bhosale2 @codecov-commenter @armantekinalp