-
Notifications
You must be signed in to change notification settings - Fork 131
(#165) feat: autoflake funtionality #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I honestly didn't have good past experience with I'm not sure, and maybe they made it better nowadays. @bhosale2 Any thought? Is there a way to run the check only before merging? |
|
@skim0119 I totally understand your concern. That's why I haven't run the formatting yet. Also about the check, the command On the other hand, the If you want to ensure safety w.r.t to code changing, should we then only have |
|
@bhosale2 Hmm.. how about we only include it in CI? Its developer's responsibility to manage their code while they are developing, but anything that goes to shared branch needs to pass formatted. Although, it reminds me when we didn't have pre-commit for black, and had bunch of commit message saying "black formatting" lol |
|
CI idea sounds good to me, as @skim0119 said developer has to format their code. |
|
Can we also include |
|
An update here (after discussion with @skim0119), |
Codecov ReportBase: 87.53% // Head: 87.53% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## update-0.3.1 #175 +/- ##
=============================================
Coverage 87.53% 87.53%
=============================================
Files 44 44
Lines 2817 2817
Branches 367 367
=============================================
Hits 2466 2466
Misses 330 330
Partials 21 21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
skim0119
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM


Fixes #165.