Skip to content

Refactor: wrappers -> modules #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bhosale2 merged 6 commits into from
Aug 16, 2022
Merged

Refactor: wrappers -> modules #177

bhosale2 merged 6 commits into from
Aug 16, 2022

Conversation

@skim0119
Copy link
Collaborator

@skim0119 skim0119 commented Aug 16, 2022

Resolve #168

@skim0119 skim0119 added update Update the codebase prio:low Priority level: low labels Aug 16, 2022
@skim0119 skim0119 added this to the Version 0.3 milestone Aug 16, 2022
@skim0119 skim0119 self-assigned this Aug 16, 2022
armantekinalp
armantekinalp approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bhosale2
bhosale2 requested changes Aug 16, 2022
View reviewed changes
Copy link
Collaborator

@bhosale2 bhosale2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mostly, super minor change.

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2022 •
edited
Loading

Codecov Report

Merging #177 (d693872) into update-0.3.0 (f9b891f) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           update-0.3.0     #177      +/-   ##
================================================
- Coverage         87.60%   87.53%   -0.07%     
================================================
  Files                43       44       +1     
  Lines              2815     2817       +2     
  Branches            367      367              
================================================
  Hits               2466     2466              
- Misses              328      330       +2     
  Partials             21       21
Impacted Files Coverage Δ
elastica/boundary_conditions.py 95.00% <ø> (ø)
elastica/modules/__init__.py 100.00% <ø> (ø)
elastica/modules/base_system.py 98.41% <ø> (ø)
elastica/modules/callbacks.py 94.87% <ø> (ø)
elastica/modules/connections.py 93.44% <ø> (ø)
elastica/modules/constraints.py 100.00% <ø> (ø)
elastica/modules/damping.py 94.87% <ø> (ø)
elastica/modules/forcing.py 100.00% <ø> (ø)
elastica/modules/memory_block.py 100.00% <ø> (ø)
elastica/systems/__init__.py 87.50% <ø> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

bhosale2
bhosale2 approved these changes Aug 16, 2022
View reviewed changes
Copy link
Collaborator

@bhosale2 bhosale2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bhosale2 bhosale2 merged commit 1ff9bc0 into GazzolaLab:update-0.3.0 Aug 16, 2022
@bhosale2 bhosale2 linked an issue Aug 16, 2022 that may be closed by this pull request
Refactor wrappers to modules #168
Closed
@bhosale2 bhosale2 mentioned this pull request Aug 16, 2022
Closed
@skim0119 skim0119 deleted the refactor/wrappers branch April 30, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bhosale2 bhosale2 bhosale2 approved these changes

@armantekinalp armantekinalp armantekinalp approved these changes

Assignees

@skim0119 skim0119

Labels

prio:low Priority level: low update Update the codebase

Projects

None yet

Milestone

Version 0.3

Development

Successfully merging this pull request may close these issues.

Refactor wrappers to modules

4 participants

@skim0119 @codecov-commenter @bhosale2 @armantekinalp