# 169: Replaced 'moviepy' with 'ffmpeg' for video generation #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rahul-JOON
changed the title
Codecov ReportBase: 87.42% // Head: 87.53% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## update-0.3.1 #232 +/- ##
================================================
+ Coverage 87.42% 87.53% +0.11%
================================================
Files 43 44 +1
Lines 2624 2817 +193
Branches 312 320 +8
================================================
+ Hits 2294 2466 +172
- Misses 309 330 +21
Partials 21 21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the video generation functionality from moviepy to ffmpeg because it is much faster and makes it uniform among other examples.
Ps: The codebase was failing some callbacks checks on my local machine, but I believe they are unrelated to my modification.