Task 1: Unit tests for common functions #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## update-0.3.2 #257 +/- ##
=================================================
+ Coverage 0 89.21% +89.21%
=================================================
Files 0 43 +43
Lines 0 2938 +2938
Branches 0 341 +341
=================================================
+ Hits 0 2621 +2621
- Misses 0 288 +288
- Partials 0 29 +29 ☔ View full report in Codecov by Sentry. |
armantekinalp
requested changes
May 15, 2023
Contributor
armantekinalp
left a comment
armantekinalp
left a comment
There was a problem hiding this comment.
There are couple of minor changes you can see the suggestions.
Also can you rename file name to test_contact_common_functions.py.
bhosale2
approved these changes
May 15, 2023
Collaborator
bhosale2
left a comment
bhosale2
left a comment
There was a problem hiding this comment.
LGTM. Good job @Rahul-JOON. @armantekinalp you can go ahead with the merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the test cases for the common functions as mentioned in issue #99.
Because the codebase is not broken, all of the test cases are now passing.