-
Notifications
You must be signed in to change notification settings - Fork 131
Task 2: Unit test for specific functions part-2 #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task 2: Unit test for specific functions part-2 #260
Conversation
armantekinalp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ul-JOON/PyElastica into 99_Contact_module_unit_tests
armantekinalp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## update-0.3.2 #260 +/- ##
================================================
+ Coverage 90.16% 91.52% +1.36%
================================================
Files 43 43
Lines 2938 2938
Branches 341 341
================================================
+ Hits 2649 2689 +40
+ Misses 260 217 -43
- Partials 29 32 +3 ☔ View full report in Codecov by Sentry. |
bhosale2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR contains the test case for the function - _calculate_contact_forces_rod_rigid_body as mentioned in #99.
Because the codebase is not broken, all of the test cases are currently passing.