Skip to content

Conversation

@Rahul-JOON
Copy link
Contributor

This PR contains the test case for the function - _calculate_contact_forces_rod_rigid_body as mentioned in #99.

Because the codebase is not broken, all of the test cases are currently passing.

Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +1.36 🎉

Comparison is base (380eecd) 90.16% compared to head (e396886) 91.52%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@               Coverage Diff                @@
##           update-0.3.2     #260      +/-   ##
================================================
+ Coverage         90.16%   91.52%   +1.36%     
================================================
  Files                43       43              
  Lines              2938     2938              
  Branches            341      341              
================================================
+ Hits               2649     2689      +40     
+ Misses              260      217      -43     
- Partials             29       32       +3     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@bhosale2 bhosale2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@armantekinalp armantekinalp merged commit d892745 into GazzolaLab:update-0.3.2 May 31, 2023
@Rahul-JOON Rahul-JOON changed the title Unit test for specific functions part-2 Task 2: Unit test for specific functions part-2 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants