Mesh init 5/6 attributes #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## update-0.3.2 #275 +/- ##
=============================================
Coverage 94.17% 94.17%
=============================================
Files 43 43
Lines 2938 2938
Branches 341 341
=============================================
Hits 2767 2767
Misses 134 134
Partials 37 37 ☔ View full report in Codecov by Sentry. |
armantekinalp
requested changes
Jul 6, 2023
Contributor
armantekinalp
left a comment
armantekinalp
left a comment
There was a problem hiding this comment.
Some minor questions/comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up the base for the mesh class in pyelastica as per issue #270
This PR contains basic code for reading an stl file and testing for the faces array's geometry that is generated.