OBJ Functioning #283
Merged
OBJ Functioning #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rahul-JOON
requested review from
armantekinalp,
bhosale2 and
skim0119
as code owners
bhosale2
added
enhancement
Ali-7800
requested changes
Jul 30, 2023
Collaborator
Ali-7800
left a comment
Ali-7800
left a comment
There was a problem hiding this comment.
minor typo, otherwise LGTM
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## update-0.3.2 #283 +/- ##
=============================================
Coverage 93.59% 93.60%
=============================================
Files 44 44
Lines 2998 3000 +2
Branches 347 347
=============================================
+ Hits 2806 2808 +2
Misses 155 155
Partials 37 37
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add .obj file format functioning to the mesh object class in #270.