Skip to content

Typing: systems #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skim0119 merged 2 commits into from
Jun 15, 2024
Merged

Typing: systems #394

skim0119 merged 2 commits into from
Jun 15, 2024

Conversation

@skim0119
Copy link
Collaborator

@skim0119 skim0119 commented Jun 13, 2024

Update

  • Finish type-hinting functions within systems directory.
  • Add MemoryEulerForward

@skim0119 skim0119 added enhancement New feature or request prio:low Priority level: low labels Jun 13, 2024
@skim0119 skim0119 requested a review from armantekinalp June 13, 2024 13:45
@skim0119 skim0119 self-assigned this Jun 13, 2024
@skim0119 skim0119 requested a review from bhosale2 as a code owner June 13, 2024 13:45
@skim0119 skim0119 mentioned this pull request Jun 13, 2024
Merged
17 tasks
@codecov
Copy link

codecov bot commented Jun 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.69%. Comparing base (4ec414a) to head (d979304).
Report is 415 commits behind head on update/mypy.

Additional details and impacted files 
@@               Coverage Diff               @@
##           update/mypy     #394      +/-   ##
===============================================
+ Coverage        87.80%   93.69%   +5.88%     
===============================================
  Files               43       53      +10     
  Lines             2943     3313     +370     
  Branches           341      352      +11     
===============================================
+ Hits              2584     3104     +520     
+ Misses             335      154     -181     
- Partials            24       55      +31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

armantekinalp
armantekinalp approved these changes Jun 15, 2024
View reviewed changes
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skim0119 skim0119 merged commit 97c8bd7 into GazzolaLab:update/mypy Jun 15, 2024
@skim0119 skim0119 deleted the typing/systems branch June 15, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@armantekinalp armantekinalp armantekinalp approved these changes

@bhosale2 bhosale2 Awaiting requested review from bhosale2

Assignees

@skim0119 skim0119

Labels

enhancement New feature or request prio:low Priority level: low

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skim0119 @armantekinalp