Skip to content

Typing: rods #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skim0119 merged 5 commits into from
Jun 16, 2024
Merged

Typing: rods #396

skim0119 merged 5 commits into from
Jun 16, 2024

Conversation

@skim0119
Copy link
Collaborator

@skim0119 skim0119 commented Jun 14, 2024 •
edited
Loading

Update

  • New rod protocol: rod/protocol.py
  • Refactor KnotTheory protocol as part of CosseratRodProtocol
  • Type-hint rod directory

@skim0119 skim0119 marked this pull request as draft June 14, 2024 15:07
@skim0119 skim0119 mentioned this pull request Jun 14, 2024
Merged
17 tasks
This was referenced Jun 15, 2024
Merged
Merged
@skim0119 skim0119 marked this pull request as ready for review June 16, 2024 00:59
@skim0119 skim0119 self-assigned this Jun 16, 2024
@skim0119 skim0119 added the enhancement New feature or request label Jun 16, 2024
armantekinalp
armantekinalp approved these changes Jun 16, 2024
View reviewed changes
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skim0119 skim0119 merged commit 439dc3d into GazzolaLab:update/mypy Jun 16, 2024
@skim0119 skim0119 deleted the typing/rods branch June 16, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@armantekinalp armantekinalp armantekinalp approved these changes

@bhosale2 bhosale2 Awaiting requested review from bhosale2

Assignees

@skim0119 skim0119

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skim0119 @armantekinalp