Skip to content

[hotfix 🔥] compute twist angle for parallel elements #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skim0119 merged 4 commits into from
Jul 15, 2024
Merged

[hotfix 🔥] compute twist angle for parallel elements #415

skim0119 merged 4 commits into from
Jul 15, 2024

Conversation

@skim0119
Copy link
Collaborator

@skim0119 skim0119 commented Jul 14, 2024 •
edited
Loading

Changes

  • Mainly address the computation for compute_twist in knot-theory.
  • Twist angle was not properly computed when two elements are completely parallel.
  • Use signed cosine angle if two elements are parallel.
  • Test added with positive/negative signed twist.

@skim0119 skim0119 self-assigned this Jul 14, 2024
armantekinalp
armantekinalp reviewed Jul 15, 2024
View reviewed changes
skim0119 and others added 3 commits July 14, 2024 20:12
@skim0119 @armantekinalp
Update elastica/rod/knot_theory.py
8de1397 
Co-authored-by: Arman Tekinalp <53585636+armantekinalp@users.noreply.github.com>
@skim0119
add test-case for pure-twist
b5cd532
@skim0119
fix: cosine angle computed with correct sign
0411926
@skim0119 skim0119 marked this pull request as ready for review July 15, 2024 01:56
@skim0119 skim0119 requested a review from bhosale2 as a code owner July 15, 2024 01:56
@skim0119 skim0119 requested a review from armantekinalp July 15, 2024 01:57
@skim0119 skim0119 changed the title [hotfix] compute twist angle for parallel elements [hotfix 🔥] compute twist angle for parallel elements Jul 15, 2024
@armantekinalp armantekinalp requested a review from Ali-7800 July 15, 2024 02:08
armantekinalp
armantekinalp approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice catch @skim0119

Ali-7800
Ali-7800 approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@Ali-7800 Ali-7800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skim0119 skim0119 merged commit 5c0a0a9 into GazzolaLab:master Jul 15, 2024
@skim0119 skim0119 deleted the hotfix/twist branch July 15, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ali-7800 Ali-7800 Ali-7800 approved these changes

@armantekinalp armantekinalp armantekinalp approved these changes

@bhosale2 bhosale2 Awaiting requested review from bhosale2 bhosale2 is a code owner

Assignees

@skim0119 skim0119

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skim0119 @Ali-7800 @armantekinalp