Fixed errors in workflow.md example code [ci skip] and bug fix in MuscularSnake example #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary of changes - `SystemSimulator` called as an instance, but no instance has been created - assign as `sim`. - corrected typo in function `dampin` to `dampen` - defined `final_time` prior to use in `add_forcing_to` - changed `from elastica.connections import FixedJoint` to `from elastica.joint import FixedJoint` - fixed missing import of `defaultdict`
samkirkham
requested review from
armantekinalp,
bhosale2 and
skim0119
as code owners
samkirkham
changed the title
Fixed RuntimeError caused by passing a scalar to `Line2D.set_xdata()` in `plot_video_with_surface()` Issue: - `com[0]` was being passed as a scalar, but matplotlib expects a sequence. Fix: - wrapped `com[0]` and `com[1]` in lists to ensure they are passed as sequences.
samkirkham
changed the title
Collaborator
|
@samkirkham Thank you for your contributions. We'll review and merge your changes in the upcoming release. |
skim0119
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workflow.mdSystemSimulatorcalled as an instance, but no instance has been created - assign assim = SystemSimulator().dampin()todampen()final_time=10prior to being passed toadd_forcing_to()from elastica.connections import FixedJointtofrom elastica.joint import FixedJointfrom collections import defaultdictexamples/MuscularSnake/post_processing.pyset_xdatareceives a sequence