Skip to content

Conversation

@tp5uiuc
Copy link
Contributor

@tp5uiuc tp5uiuc commented May 26, 2022

Adds functionality to track velocity of the rod to check if the simulation is close to reaching the quasi-steady state.

Apologies for adding a new branch to the main repo, I was in a hurry.

@tp5uiuc tp5uiuc added the update Update the codebase label May 26, 2022
@tp5uiuc tp5uiuc requested review from armantekinalp and bhosale2 May 26, 2022 03:58
@tp5uiuc tp5uiuc self-assigned this May 26, 2022
@bhosale2 bhosale2 changed the base branch from master to update-0.3.0 May 26, 2022 03:59
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2022

Codecov Report

Merging #97 (dfa9869) into update-0.3.0 (5f15801) will increase coverage by 87.06%.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           update-0.3.0      #97       +/-   ##
=================================================
+ Coverage              0   87.06%   +87.06%     
=================================================
  Files                 0       41       +41     
  Lines                 0     2535     +2535     
  Branches              0      344      +344     
=================================================
+ Hits                  0     2207     +2207     
- Misses                0      306      +306     
- Partials              0       22       +22     
Impacted Files Coverage Δ
elastica/wrappers/__init__.py 100.00% <0.00%> (ø)
elastica/wrappers/memory_block.py 100.00% <0.00%> (ø)
elastica/version.py 0.00% <0.00%> (ø)
elastica/external_forces.py 95.18% <0.00%> (ø)
elastica/rigidbody/data_structures.py 44.82% <0.00%> (ø)
elastica/_linalg.py 95.65% <0.00%> (ø)
elastica/wrappers/connections.py 93.44% <0.00%> (ø)
elastica/rod/knot_theory.py 97.97% <0.00%> (ø)
elastica/utils.py 98.00% <0.00%> (ø)
elastica/timestepper/__init__.py 100.00% <0.00%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f15801...dfa9869. Read the comment docs.

Copy link
Collaborator

@bhosale2 bhosale2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change.

Copy link
Contributor

@armantekinalp armantekinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhosale2 bhosale2 self-requested a review May 26, 2022 04:11
Copy link
Collaborator

@bhosale2 bhosale2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bhosale2 bhosale2 merged commit 46ad665 into update-0.3.0 May 26, 2022
@bhosale2 bhosale2 deleted the wip_add_norms_examples branch May 26, 2022 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

update Update the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants