Skip to content

Conversation

@summersz
Copy link
Contributor

@summersz summersz commented Oct 13, 2023

implement a helper function to transform multidict into dict with lists
accept and return single values as a list if a list type is expected

closes #23

implement a helper function to transform multidict into dict with lists
accept and return single values as a list if a list type is expected
@summersz summersz closed this Oct 14, 2023
@summersz summersz reopened this Oct 16, 2023
@summersz summersz changed the title feat: support lists from form, query and file request inputs feat: support lists from form, query and file request inputs. closes #20. Oct 27, 2023
@summersz summersz changed the title feat: support lists from form, query and file request inputs. closes #20. feat: support lists from form, query and file request inputs. closes #23. Oct 31, 2023
@summersz summersz changed the title feat: support lists from form, query and file request inputs. closes #23. feat: support lists from form, query and file request inputs Oct 31, 2023
@Ge0rg3
Copy link
Owner

Ge0rg3 commented Nov 16, 2023

Hey @summersz thanks for the PR!
This currently does raise one issue:
The validator:

nicknames: List[str] = Json()

Should only explicitly allow lists, but under this implementation the value would be autoconverted, which ideally should only occur for input types without explicit list implementations. Let me make a couple changes to resolve this and we should be good to go 🙌

@Ge0rg3 Ge0rg3 merged commit c08dfba into Ge0rg3:master Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support multiple values for same parameter

2 participants