Skip to content

Conversation

@smt5541
Copy link
Collaborator

@smt5541 smt5541 commented Feb 11, 2024

Primarily: Adds Unit Tests for most cases I could think of
Additionally: Fixes a few bugs I found along the way:

  • Minumum string length does not work #37
  • v: int = Query(func) custom validation function would receive str values
  • v: Union[bool, int] = Query() would fail because int values cannot have .lower() called on them
  • v: List[str] = Query() custom validation function would receive individual str values instead of the whole list
  • Negative int values were not accepted by Route parameters due to upstream behavior in Flask. Applied the Query parsing of str values to Route to allow paths of /<v> to be received correctly by a v: int = Route() parameter
  • v: FileStorage = File(min_length=300) would fail when it shouldn't when using the Flask built-in dev server

…t was provided (as int has no attribute 'lower')
…unning with the provided List object (instead ran with the children)
… fix datetime.* assignment and compress list assertion logic
@Ge0rg3
Copy link
Owner

Ge0rg3 commented Feb 19, 2024

Closing as changes included in #40 👍

@Ge0rg3 Ge0rg3 closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants