-
Notifications
You must be signed in to change notification settings - Fork 13
Add Unit Testing GitHub CI #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om Query parameters
…eing passed to provided func
…erent Parameter subclasses
…t was provided (as int has no attribute 'lower')
…unning with the provided List object (instead ran with the children)
…te, datetime.time child types
… fix datetime.* assignment and compress list assertion logic
…str_length and max_str_length tests to 2
… Route parameters
Add GitHub CI
Owner
|
Closing as changes included in #40 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily: Adds Unit Tests for most cases I could think of
Additionally: Fixes a few bugs I found along the way:
v: int = Query(func)custom validation function would receivestrvaluesv: Union[bool, int] = Query()would fail becauseintvalues cannot have.lower()called on themv: List[str] = Query()custom validation function would receive individualstrvalues instead of the wholelistintvalues were not accepted byRouteparameters due to upstream behavior in Flask. Applied theQueryparsing ofstrvalues toRouteto allow paths of/<v>to be received correctly by av: int = Route()parameterv: FileStorage = File(min_length=300)would fail when it shouldn't when using the Flask built-in dev server