Fix Async View Handling #41
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding async support for Flask-Parameter-Validation, the ValidateParameters decorator would always return an async coroutine, whether the Flask view function was async or not. This resulted in unexpected behavior when adding decorators that wrapped ValidateParameters as they may not have been expecting an async function that must be awaited.
To fix this, ValidateParameters now only returns an async coroutine to any decorators upstream if it recieved an async coroutine. Otherwise, it will return a function.
I've added a good few tests to make sure async and sync decorators are handled predictably across types and parameter types.