Wladiz2001 patch 1 #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option allows the modal to be centered vertically verticalCentered: true/false (default: false)
This option allows the modal to be centered vertically, verticalCentered: true/false (default: false)
This option allows the modal to be centered vertically, verticalCentered: true/false (default: false)
Owner
|
This looks great thank you! Seems like you got it all! :) Which minify did you use for the .js min? |
Author
|
I use UglifyJS 3 for minify, This tool decreases the size a little more than the one used previously. |
Owner
|
ok i'm going to need to bring this in manually :) I can't risk doing an update where there may be malicious code in the min file, For reference, please only update the source files, we minify and build on our side before we set out a release, this is pretty standard practice |
Owner
|
@wladiz2001 can you please remove the min file from the commit? find time stretched out sorry :( |
Author
|
Ok, I delete de min files. Thanks for the explanation |
GedMarc
added a commit
that referenced
this pull request
Jan 30, 2022
Thanks to @wladiz2001 for verticalCentered support #40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add verticalCentered option
This option allows the modal to be centered vertically,
verticalCentered: true/false (default: false)