Update jquery-ui and jszip modules to advance firefox compatibility efforts#46
Open
bomberm wants to merge 3 commits intoGenderMagProject:masterfrom
Open
Update jquery-ui and jszip modules to advance firefox compatibility efforts#46bomberm wants to merge 3 commits intoGenderMagProject:masterfrom
bomberm wants to merge 3 commits intoGenderMagProject:masterfrom
Conversation
added 3 commits
June 6, 2019 11:31
roseg31
pushed a commit
that referenced
this pull request
Aug 24, 2020
Ensures previously saved subgoals are not overwritten when the user clicks on them before saving the current subgoal. Calling drawSubgoal with a different id is restricted to after the current subgoal has been saved.
pujagarwal
approved these changes
May 24, 2021
pujagarwal
approved these changes
May 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assistant requires two JavaScript Libraries that are considered unsafe by Firefox.
I have created a guide (labelled Firefox Add-On generation) that expands upon the windowsclub guide to fill in the gap of work needed to generate a firefox xpi so that future work is not starting from zero. This has steps not only for the xpi generation, but also the Firefox Add-on signing process.
This pull request is for effort to address issue #11, but does not fully resolve the issue.
The tools recommended within issue #11 are not enough to convert the GenderMagRecorderAssistant. While I have been able to create a test .xpi, dependencies on chrome specific methods meant the assistant was non-functional. This pull request is an effort to bring GenderMagRecordersAssistant closer to firefox compatibility.