refactor, platform extensions and app#13
Open
alex2awesome wants to merge 11 commits intoGeneralUserModels:mainfrom
Open
refactor, platform extensions and app#13alex2awesome wants to merge 11 commits intoGeneralUserModels:mainfrom
alex2awesome wants to merge 11 commits intoGeneralUserModels:mainfrom
Conversation
Author
|
Latest app version: https://drive.google.com/file/d/17TLgNDSHuH6ydaI8nBwUJ6F30M9ZZ729/view?usp=drive_link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made the following changes:
New features:
Refactor:
cli/andapp/are separate folders and they each try to handle as little functionality as possible. The only things they handle are basically:app/macosneeds to run keyboard tracking in the foreground for security concerns.gum/orchestrates the events, locks and semafors to make sure the users events are all getting logged in order (I think it was an error I observed in earlier versions, but I could be wrong)observers/now handles most of the meat of the actual tracking. I included a blank folder for windows expansion and other platform expansion as need be, going forward.Please give it a quick scan. I can do more work to make it a bit more legible. There were a few parts that I vibe coded out of frustration when the keyboard tracking wasn't working (😭) and some of the more cross-browser URL checking.