Smaller jump table#56
Merged
butterunderflow merged 1 commit intoGenerative-Program-Analysis:debug_retfrom Oct 10, 2024
Merged
Conversation
Member
|
Looks good to me! Indeed it is not necessary to append trail into a new function call. Feel free to merge. |
Kraks
added a commit
that referenced
this pull request
Oct 13, 2024
* a failed test case * update tribonacci.wat * fix and test return behavior * validation of return.wat * `trail` is local jump table (#56) * use rust compiled tribonacci.wat(a data section involved) * keep both versions of tribonacci --------- Co-authored-by: butterunderflow <azhong.934@gmail.com> Co-authored-by: butterunderflow <112108686+butterunderflow@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think we have an invariant that
retis always smaller than the size oftrail, and this PR utilize this invariant to minimizetrail's size. Intuitively, trail represent a local jump table in current calling frame.trailstill needs to be caught bynewK.