Enable CI testing for long options#2305
Merged
seisman merged 1 commit intolongoptionsparsingfrom Dec 20, 2019
Merged
Conversation
PaulWessel
approved these changes
Dec 20, 2019
PaulWessel
added a commit
that referenced
this pull request
Dec 21, 2019
* WIP Explore adding long-format GMT options This branch is work in progress on adding long-format option parsing to GMT. E.g., --region=w/e/s/n instead of -Rw/e/s/n, --registration=pixel instead of -r, and so on. At the moment only the common options and their most basic forms have been implemented, as well as local options for blockmean. I will write more later about how this all works and what is required to be added to each module - blockmean.c static variable local_kw shows how. * More common option long-format words Update long-syntax for -U and -s. * Update mgd77track.c Merge from master missed the new NULL argument.. * Add separator variable to GMT_KW_DICT Needed to split parsing of options that are given as a series of arguments separated by slashes (e.g., xinc/yinc) or commas (e.g., input columns). * Let -T option be a modifer under -C The -T and -C are dealing with the same issue: The text bounding box atrributes. I have combined these with -T now being a modifer +t<shape> under -C. Tests pass, documentation has been updated. * Remove the ifdef USE_GMT_KWD No point having this since this is a separate branch for testing anyway. * Implement parsing of sections Added code to handle multi-section arguments such as --increments=30+e/50+n * Documentation Improve the documentation of the new gmtinit_kw_replace function that converts long-format GMT options to standard short-format options. * Fix a few issues missing args to gmt_init_module. * Seppl out structure name KEYWORD_DICTIONARY * rename a few keywords Sucn as read-columns and write-columns. * Add grdinterpolate to the mix and fix some errors * Let keyword dictionary be ifdef under USE_LONG_OPTIONS This means it can be merged into master with no side-effects since developers must define USE_LONG_OPTIONS for any keywords to be defined. * Minor text improvements * Fix the use of USE_LONG_OPTIONS * Update ConfigUserTemplate.cmake Forgot it has to be a define, not cmake variable. * Add --frame * Rename kw arrays to make it clearer that one is module-specific * Update src/blockmean.c Co-Authored-By: Dongdong Tian <seisman.info@gmail.com> * Fix issues in block_subs.c * Update src/gmt_init.c Co-Authored-By: Dongdong Tian <seisman.info@gmail.com> * Update src/gmt_init.c Co-Authored-By: Dongdong Tian <seisman.info@gmail.com> * Adding axes as keyword Better docs for code, longer variables, fixing some bugs. * Escape +? strings that should not be seen as modifiers * Move --increment to block_subs.c, update commons, use --axis --frame=axes sets which axes to draw, and --axis specifies the settings of an axis. * Enable CI testing for long options (#2305) * Add a long-format option test to test/modern * Improve coments only Co-authored-by: Leonardo Uieda <leouieda@gmail.com> Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add following statements to CI cmake script.