Fix the bug when passing pixel-registered matrix as grids#3503
Merged
Fix the bug when passing pixel-registered matrix as grids#3503
Conversation
PaulWessel
approved these changes
Jun 20, 2020
Member
Author
|
@PaulWessel You can work on this branch directly. No need to merge it into master. |
Member
|
OK, need to wrap another debug first... |
5 tasks
Member
|
The gmtapi_init_matrix confused what the offset argument to gmt_M_get_n should be (it should be the registration, but we passed 0.5 * registration). To add insult to injury, we did not set the matrix registration using the input registration, hence the matrix was always gridline registered. |
Member
|
I checked that gmt_M_get_n is used correctly everywhere else. |
Member
Author
|
Great! Please add some comments to |
Member
|
I've added the test and comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Fixes #3502
Reminders
masterfor new features,6.1for bug fixes