Replace underscores with hyphens in projection gallery file names.#1024
Closed
willschlitzer wants to merge 7 commits intomasterfrom
Closed
Replace underscores with hyphens in projection gallery file names.#1024willschlitzer wants to merge 7 commits intomasterfrom
willschlitzer wants to merge 7 commits intomasterfrom
Conversation
Member
|
Shall we add this rule in CONTRIBUTING.md? |
Member
|
https://github.com/GenericMappingTools/pygmt/tree/master/examples/projections/table Also need to update all the |
Contributor
Author
Fixed in 4b6fb8d |
5 tasks
Member
|
Close this one, as we'll use underscores (#1034 (comment)). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #995, the project is inconsistent with under underscores or hyphens in file names, and advocates switching every file name to use hyphens. This PR makes that change for the projection gallery examples.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version