Conversation
willschlitzer
changed the title
weiji14
reviewed
May 3, 2021
Member
There was a problem hiding this comment.
Still need to alias -L, -U, -V, -t and add the docstring in for these new parameters. Pro tip: copy them from https://github.com/GenericMappingTools/gmt/blob/master/doc/rst/source/histogram_common.rst_.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
willschlitzer
changed the title
seisman
reviewed
May 5, 2021
seisman
reviewed
May 5, 2021
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
May 9, 2021
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
weiji14
reviewed
May 10, 2021
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14
approved these changes
May 11, 2021
Member
weiji14
left a comment
weiji14
left a comment
There was a problem hiding this comment.
Just one minor comment on how we want to sort the docstrings, otherwise I'm happy with the content 😄
weiji14
added
the
final review call
seisman
approved these changes
May 11, 2021
Member
seisman
left a comment
seisman
left a comment
There was a problem hiding this comment.
Looks good to me, except a tiny comment.
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
removed
the
final review call
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com> Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This wraps additional parameters for
histogram.Preview at https://pygmt-git-parameters-histogram-gmt.vercel.app/api/generated/pygmt.Figure.histogram.html
Continuation of work on #563
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version